8000 fix: five digit waitlist size by emilyjablonski · Pull Request #4935 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: five digit waitlist size #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2025
Merged

fix: five digit waitlist size #4935

merged 5 commits into from
Jun 5, 2025

Conversation

emilyjablonski
Copy link
Collaborator
@emilyjablonski emilyjablonski commented Jun 3, 2025

This PR addresses #4858

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Fixes a wrapping issue where waitlists with 4+ digits were wrapping onto multiple lines - does so by uptaking latest UIC.

How Can This Be Tested/Reviewed?

Compare this listing on dev to the same listing on this deploy preview and ensure it no longer wraps the number of spots.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 9b332a1
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6840691a2333830008024193
😎 Deploy Preview https://deploy-preview-4935--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 9b332a1
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6840691a85a06f00083587dd
😎 Deploy Preview https://deploy-preview-4935--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 9b332a1
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6840691a233383000802418e
😎 Deploy Preview https://deploy-preview-4935--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Jun 3, 2025
@emilyjablonski emilyjablonski changed the title fix: three digit waitlist size fix: five digit waitlist size Jun 3, 2025
Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 9b332a1
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/6840691a19a63000084a82e1
😎 Deploy Preview https://deploy-preview-4935--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review June 3, 2025 21:58
@emilyjablonski emilyjablonski added 1 review needed Requires 1 more review before ready to merge and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Jun 3, 2025
Copy link
Collaborator
@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚯

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 3, 2025
@emilyjablonski emilyjablonski merged commit 58b6f51 into main Jun 5, 2025
29 checks passed
@emilyjablonski emilyjablonski deleted the 4858/waitlist-fix branch June 5, 2025 16:33
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 12, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0