8000 fix: Unit groups drawer previous data bug by matzduniuk · Pull Request #4936 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Unit groups drawer previous data bug #4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

fix: Unit groups drawer previous data bug #4936

merged 4 commits into from
Jun 4, 2025

Conversation

matzduniuk
Copy link
Collaborator

This PR addresses #4904

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

  • Fix an issue where previously opened unit group drawer data persists between different drawers

How Can This Be Tested/Reviewed?

  • Go to /listings/add in the admin panel
  • Select a jurisdiction with the enableUnitGroups flag set to true
  • Go to the units section and click Add Unit Group
  • Fill out the drawer data and save the unit group
  • Click edit on the newly added unit group and close the drawer without any changes
  • Click Add Unit Group
  • The new unit group from drawer should have no of the data previously set for the added unit group

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk self-assigned this Jun 3, 2025
@matzduniuk matzduniuk added the 1 review needed Requires 1 more review before ready to merge label Jun 3, 2025
@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit ea344f2
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/683ffae1abfa3d00080479fd
😎 Deploy Preview https://deploy-preview-4936--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit ea344f2
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/683ffae12908ff0008abaa0e
😎 Deploy Preview https://deploy-preview-4936--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit ea344f2
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/683ffae1b5ecc9000886abfb
😎 Deploy Preview https://deploy-preview-4936--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit ea344f2
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/683ffae1ac46ea0009406f77
😎 Deploy Preview https://deploy-preview-4936--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski changed the title Fix: Unit groups drawer previous data bug fix: Unit groups drawer previous data bug Jun 3, 2025
emilyjablonski
emilyjablonski approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator
@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐻‍❄️

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 3, 2025
@matzduniuk matzduniuk merged commit 4a006d3 into main Jun 4, 2025
29 checks passed
@matzduniuk matzduniuk deleted the 4904/unit-groups-drawer-bug branch June 4, 2025 08:30
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 4, 2025
@matzduniuk @emilyjablonski @ludtkemorgan
fix: fix edit unit group drawer data persistence (bloom-housing#4936)
997f94e 
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 5, 2025
@matzduniuk @emilyjablonski @ludtkemorgan
fix: fix edit unit group drawer data persistence (bloom-housing#4936)
e7b7685 
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
matzduniuk added a commit to housingbayarea/bloom that referenced this pull request Jun 5, 2025
@matzduniuk @emilyjablonski
fix: fix edit unit group drawer data persistence (bloom-housing#4936)
0fafb06 
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
@ludtkemorgan ludtkemorgan mentioned this pull request Jun 5, 2025
Open
9 tasks
matzduniuk added a commit to housingbayarea/bloom that referenced this pull request Jun 13, 2025
@matzduniuk @emilyjablonski
fix: fix edit unit group drawer data persistence (bloom-housing#4936) (…
7300709 
…#915)

Co-authored-by: Emily Jablonski <65367387
840C
+emilyjablonski@users.noreply.github.com>
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 18, 2025
@matzduniuk @emilyjablonski @ludtkemorgan
fix: fix edit unit group drawer data persistence (bloom-housing#4936)
467d606 
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyjablonski emilyjablonski emilyjablonski approved these changes

Assignees

@matzduniuk matzduniuk

Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzduniuk @emilyjablonski
0