10000 fix: see all under construction button by emilyjablonski · Pull Request #4939 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: see all under construction button #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

fix: see all under construction button #4939

merged 2 commits into from
Jun 3, 2025

Conversation

emilyjablonski
Copy link
Collaborator
@emilyjablonski emilyjablonski commented Jun 3, 2025

This PR addresses #4678

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Addresses a QA note that the under construction section should have a button underneath it that links to a filtered listings view for all under construction listings.

How Can This Be Tested/Reviewed?

Start the application up in the Lakeview jurisdiction and ensure the button is present (design).

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Rev 8000 iew Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit c80cdd7
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/683f69625521ce00081859e7
😎 Deploy Preview https://deploy-preview-4939--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit c80cdd7
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/683f6962e3820000085f701f
😎 Deploy Preview https://deploy-preview-4939--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit c80cdd7
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/683f6962527a9200083add87
😎 Deploy Preview https://deploy-preview-4939--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 3, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit c80cdd7
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/683f69624365ab00082ba163
😎 Deploy Preview https://deploy-preview-4939--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review June 3, 2025 21:33
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Jun 3, 2025
Copy link
Collaborator
@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐶

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 3, 2025
@emilyjablonski emilyjablonski merged commit 797ebea into main Jun 3, 2025
29 checks passed
@emilyjablonski emilyjablonski deleted the 4678/button branch June 3, 2025 22:33
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 4, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 5, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0