8000 fix: undefined to null by ColinBuyck · Pull Request #4933 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: undefined to null #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

fix: undefined to null #4933

merged 2 commits into from
Jun 3, 2025

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses #4795

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This is a quick follow up to #4930 since the undefined default cannot be serialized when the jurisdiction does not have swapCommunityTypesForPrograms enabled. The error below explains the simple fix
Screenshot 2025-06-02 at 11 40 44 PM

How Can This Be Tested/Reviewed?

Reseed, run public with Bloomington Jurisdiction, and the listings page should render without the blocking error above.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after t 8000 he updates

@ColinBuyck ColinBuyck requested a review from mcgarrye June 3, 2025 06:47
@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Jun 3, 2025
@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit a26a45a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/683efca1b2ddc90008471c1d
😎 Deploy Preview https://deploy-preview-4933--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit a26a45a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/683efca1736b6b0008b454f2
😎 Deploy Preview https://deploy-preview-4933--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit a26a45a
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/683efca1abb32e000852f662
😎 Deploy Preview https://deploy-preview-4933--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 3, 2025 •
edited
Loading

✅ Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit a26a45a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/683efca1d826770008c8eef1
😎 Deploy Preview https://deploy-preview-4933--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

mcgarrye
mcgarrye approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator
@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 3, 2025
@emilyjablonski emilyjablonski merged commit fb3f328 into main Jun 3, 2025
29 checks passed
@emilyjablonski emilyjablonski deleted the 4795/unserializable-error branch June 3, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcgarrye mcgarrye mcgarrye approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinBuyck @mcgarrye @emilyjablonski
0