fix: functioning search and multiselect #4940
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3c9583f to
0b22199
Compare
3c7f8d3 to
c0a05d4
Compare
sites/public/__tests__/components/browse/FilterDrawerHelpers.test.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/browse/FilterDrawerHelpers.test.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/browse/FilterDrawerHelpers.test.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/browse/FilterDrawerHelpers.test.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/browse/FilterDrawerHelpers.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This LGTM. Just confirming that if the swap community types toggle is off, we're not supposed to see the reserved community types instead? The ticket indicates that is the case, but I feel like we spoke offline and determined this should only do the community type work and didn't update the ticket. Regardless, I would suggest that be future work anyway since we won't release that version soon.
|
@ludtkemorgan Thanks for the testing advice! Added the tests you recommended! @emilyjablonski You are remembering correctly that we determined that wasn't desired work right now. I updated the linked ticket and still made an optional ticket stub if we end up revisiting the epic and wanted to add the functionality #4996 Going to merge once tests pass 🦺 |
This PR addresses #4795
Description
This PR does three primary things:
How Can This Be Tested/Reviewed?
This can be tested locally by reseeding and testing the two new filters. Update the listing data and see the filtering results reflect those updates. Also a code walkthrough of the tests to see if any gaps come up would be helpful!
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: