8000 Fix: update listing card to show no preview table if data is empty by matzduniuk · Pull Request #5012 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: update listing card to show no preview table if data is empty #5012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: update listing card to show no preview table if data is empty #5012

wants to merge 2 commits into from
+343 −25

Conversation

matzduniuk
Copy link
Collaborator

This PR addresses #4928

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

  • Update listing browse card not to render the units/unit groups preview table when no data is available
  • Add unit tests to cover units/unit groups preview table rendering

How Can This Be Tested/Reviewed?

  • Go to the partner's site and clear all unit groups from the listing
  • Go to the public site /listings page
  • The cleared listing card should not show any table

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk self-assigned this Jun 23, 2025
@matzduniuk matzduniuk added the 1 review needed Requires 1 more review before ready to merge label Jun 23, 2025
@netlify Netlify
Copy link
netlify bot commented Jun 23, 2025

✅ Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 20aaec9
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/68595c0eab38f40008e8c566
😎 Deploy Preview https://deploy-preview-5012--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 23, 2025

✅ Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 20aaec9
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/68595c0e04866f0008dc2d47
😎 Deploy Preview https://deploy-preview-5012--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 23, 2025

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 20aaec9
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/68595c0e377e330008beff8b
😎 Deploy Preview https://deploy-preview-5012--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 23, 2025

✅ Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 20aaec9
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/68595c0eb18ec400088679eb
😎 Deploy Preview https://deploy-preview-5012--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matzduniuk matzduniuk

Labels
1 review needed Requires 1 more review before ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matzduniuk
0