8000 Remove/change old msgtraps by mponomar · Pull Request #5161 · bloomberg/comdb2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove/change old msgtraps #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Remove/change old msgtraps #5161

merged 2 commits into from
May 30, 2025

Conversation

mponomar
Copy link
Contributor

To help us review your pull request, please consider providing an overview of the following:

  • What is the type of the change (bug fix, feature, documentation and etc.) ?
  • What are the current behavior and expected behavior, if this is a bugfix ?
  • What are the steps required to reproduce the bug, if this is a bugfix ?
  • What is the current behavior and new behavior, if this is a feature change or enhancement ?
  • [Optional] Why is the new behavior better than the current behavior, if this is a feature change ?

@mponomar mponomar force-pushed the remove-obsolete-mtraps branch from 81bf057 to 17aecc9 Compare May 15, 2025 20:15
roborivers
roborivers suggested changes May 15, 2025
View reviewed changes
Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 10/607 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
fdb_compat_rte_connect_generated
fdb_compat
load_cache_dumpmax_generated
load_cache
auth_twofiles_generated
auth_queueodh_generated
auth
sc_timepart
sc_downgrade

@mponomar mponomar force-pushed the remove-obsolete-mtraps branch 2 times, most recently from b6d26e3 to 9272d94 Compare May 22, 2025 18:39
@mponomar mponomar force-pushed the remove-obsolete-mtraps branch 2 times, most recently from 9f5513b to c77b3e4 Compare May 28, 2025 16:54
@mponomar
Remove/fix some obsolete msgtraps
b685ea1 
Signed-off-by: Mike Ponomarenko <mponomarenko@bloomberg.net>
@mponomar mponomar force-pushed the remove-obsolete-mtraps branch from c77b3e4 to b685ea1 Compare May 28, 2025 17:15
@mponomar
Add is_connection_local()
2b4d0aa 
Signed-off-by: Mike Ponomarenko <mponomarenko@bloomberg.net>
@mponomar mponomar merged commit f738472 into bloomberg:main May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers requested changes

@riverszhang89 riverszhang89 riverszhang89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mponomar @riverszhang89 @roborivers
0