8000 net: accept-thd (main event_base) tracks appsock count by akshatsikarwar · Pull Request #5192 · bloomberg/comdb2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

net: accept-thd (main event_base) tracks appsock count #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akshatsikarwar
Copy link
Contributor
@akshatsikarwar akshatsikarwar commented Jun 3, 2025

@markhannum Reported this while running sqlqueries test.

This fixes race in closing an evicted connection. Also fixes active connection accounting.

@akshatsikarwar
Copy link
Contributor Author
akshatsikarwar commented Jun 3, 2025

/plugin-branch appsock-limit

Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 19/610 tests failed ⚠.

The first 10 failing tests are:
lock_maxid [setup failure]
analyze_recover_deadlock [setup failure]
tmptbl_starve [setup failure]
tablelocks [setup failure]
sc_newuniq_logicalsc_generated [setup failure]
deadlock_policy [setup failure]
typessql [setup failure]
fdb_push_rte_connect_generated [setup failure]
long_db_name [setup failure]
curmoves_sockbplog_generated [setup failure]

Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 14/610 tests failed ⚠.

The first 10 failing tests are:
curmoves [setup failure]
cancel_sql [setup failure]
insert_lots_large_tran_generated
sc_timepart
autoanalyze
appsock
close_old_connections
unionpar_maxqueue
sc_lotsoftables_logicalsc_generated
sc_lotsoftables

Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/610 tests failed ⚠.

The first 10 failing tests are:
curmoves_sockbplog_generated [setup failure]
cancel_sql [setup failure]
insert_lots_large_tran_generated
appsock
close_old_connections
phys_rep_tiered_nosource_generated
selectv_rcode_serialretry_generated
guid
incoherent_sql
consumer

Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 13/610 tests failed ⚠.

The first 10 failing tests are:
lock_maxid [setup failure]
curmoves [setup failure]
curmoves_sockbplog_generated [setup failure]
close_old_connections [setup failure]
cancel_sql [setup failure]
updater_latency
sc_inserts_deletes_partial_index_off_generated
systable_locking
sc_timepart
sc_constraints

Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/610 tests failed ⚠.

The first 10 failing tests are:
lock_maxid [setup failure]
curmoves_sockbplog_generated [setup failure]
curmoves [setup failure]
close_old_connections [setup failure]
sc_inserts_deletes
sc_transactional_rowlocks_generated
sp_queueodh_generated
phys_rep_tiered_firstfile_generated
sc_downgrade
cldeadlock

markhannum
markhannum previously approved these changes Jun 6, 2025
Signed-off-by: Akshat Sikarwar <asikarwar1@bloomberg.net>
Signed-off-by: Akshat Sikarwar <asikarwar1@bloomberg.net>
Copy link
@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/610 tests failed ⚠.

The first 10 failing tests are:
sc_constraints_logicalsc_generated
reco-ddlk-sql
sc_downgrade
unionpar_maxqueue
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
guid
incoherent_sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0