-
Notifications
You must be signed in to change notification settings - Fork 33
Stop Background scroll behind Modal #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- wrote a Service which will insert & remove the (.modal-open) class in the body Tag
- We have to call it whenever making state T/F for calling the modal
Can you show an example what this solves? |
In this Video, whenever a modal (confirmation/password /Network change) appears on the screen. I am trying to scroll the background, but it is locked in its place, which should be standard. Earlier, we could scroll the background behind the modal Screen.Recording.2025-06-10.at.12.18.17.AM.movEarlier: Screen.Recording.2025-06-10.at.12.23.30.AM.mov |
Hey @dangershony, can you please check the implementation? Once you green light it, I will propagate this to other modals in the code |
@@ -61,6 +61,28 @@ | |||
<script src="nostr-tools-methods.js?v=1" type="module"></script> | |||
<script src="/assets/js/appUpdate.js?v=1"></script> | |||
<script src="/assets/js/app.js?v=1"></script> | |||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this code to wwwroot/assets/ja/app.js
Many modals are not fixed yet and you need to create a service for all modals. |
a service for each model sounds wrong to me |
Yeah I have written this service |