8000 Stop Background scroll behind Modal by yashop7 · Pull Request #415 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop Background scroll behind Modal #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yashop7
Copy link
Contributor
@yashop7 yashop7 commented Jun 9, 2025
  • wrote a Service which will insert & remove the (.modal-open) class in the body Tag
  • We have to call it whenever making state T/F for calling the modal

@yashop7 yashop7 marked this pull request as draft June 9, 2025 09:08
@dangershony
Copy link
Member

Can you show an example what this solves?

@yashop7
Copy link
Contributor Author
yashop7 commented Jun 9, 2025

In this Video, whenever a modal (confirmation/password /Network change) appears on the screen. I am trying to scroll the background, but it is locked in its place, which should be standard. Earlier, we could scroll the background behind the modal

Screen.Recording.2025-06-10.at.12.18.17.AM.mov

Earlier:

Screen.Recording.2025-06-10.at.12.23.30.AM.mov

@yashop7
Copy link
Contributor Author
yashop7 commented Jun 19, 2025

Hey @dangershony, can you please check the implementation? Once you green light it, I will propagate this to other modals in the code

@@ -61,6 +61,28 @@
<script src="nostr-tools-methods.js?v=1" type="module"></script>
<script src="/assets/js/appUpdate.js?v=1"></script>
<script src="/assets/js/app.js?v=1"></script>
<script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this code to wwwroot/assets/ja/app.js

@miladsoft
Copy link
Member

Many modals are not fixed yet and you need to create a service for all modals.

@dangershony
Copy link
Member

Many modals are not fixed yet and you need to create a service for all modals.

a service for each model sounds wrong to me

@yashop7
Copy link
Contributor Author
yashop7 commented Jun 20, 2025

Yeah I have written this service Services/ModalScrollService.cs, I will use this to stop modal everywhere in code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
488B None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0