-
Notifications
You must be signed in to change notification settings - Fork 33
Seed Phrase Suggestion Bug #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed Phrase Suggestion Bug #421
Conversation
src/Angor/Client/Pages/Wallet.razor
Outdated
@@ -178,7 +179,7 @@ | |||
!string.IsNullOrWhiteSpace(userVerificationInputs[wordIndex])) | |||
{ | |||
var suggestions = GetFilteredWordSuggestions(userVerificationInputs[wordIndex]); | |||
@if (suggestions.Any()) | |||
if (!(suggestions.Count() == 1 && suggestions.First().Equals(userVerificationInputs[wordIndex], StringComparison.OrdinalIgnoreCase)) && suggestions.Any()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the point of this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI if you put suggestions.Any()
first you wont have to check suggestions.Count() == 1
then I think you can reduce to
if(suggestions.Any() && suggestions[0] != userVerificationInputs[wordIndex])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashop7 can you fix this so this can go in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah Dan, you are right, made the change
This bug didn't exist when I created this. I think maybe there was a bug somewhere else that affected this CSS as well. |
@dangershony I request you to let me look into this matter. |
you think the bug is in css only? sure have a look |
I'm sure this bug didn't exist. |
Its odd when I use the version in master the suggestion is not gone when I lose focus. |
the issue was that onblur get's triggered before onclick, that's why when we click some option on the dropdown, in meantime onblur removes the focus so option selected wasn't reflected, so now I added a delay in onblur, now it's working fine, In my case earlier onclick was triggering before onblur, so it was working fine for me |
Before:
Screen.Recording.2025-06-12.at.1.40.27.AM.mov
After:
Screen.Recording.2025-06-12.at.1.38.52.AM.mov