8000 Seed Phrase Suggestion Bug by yashop7 · Pull Request #421 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Seed Phrase Suggestion Bug #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

yashop7
Copy link
Contributor
@yashop7 yashop7 commented Jun 11, 2025
  • Suggestions gone after you removed focus from the particular Tab
  • Suggestion also gone after you fully typed the phrase
  • Minor change in Placeholder text

Before:

Screen.Recording.2025-06-12.at.1.40.27.AM.mov

After:

Screen.Recording.2025-06-12.at.1.38.52.AM.mov

@@ -178,7 +179,7 @@
!string.IsNullOrWhiteSpace(userVerificationInputs[wordIndex]))
{
var suggestions = GetFilteredWordSuggestions(userVerificationInputs[wordIndex]);
@if (suggestions.Any())
if (!(suggestions.Count() == 1 && suggestions.First().Equals(userVerificationInputs[wordIndex], StringComparison.OrdinalIgnoreCase)) && suggestions.Any())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point of this line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI if you put suggestions.Any() first you wont have to check suggestions.Count() == 1
then I think you can reduce to
if(suggestions.Any() && suggestions[0] != userVerificationInputs[wordIndex])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashop7 can you fix this so this can go in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Dan, you are right, made the change

@miladsoft
Copy link
Member

This bug didn't exist when I created this. I think maybe there was a bug somewhere else that affected this CSS as well.

@miladsoft
Copy link
Member

@dangershony I request you to let me look into this matter.

@dangershony
Copy link
Member

@dangershony I request you to let me look into this matter.

you think the bug is in css only? sure have a look

@miladsoft
Copy link
Member

I'm sure this bug didn't exist.

@dangershony
Copy link
Member

Its odd when I use the version in master the suggestion is not gone when I lose focus.
but also it seems on this branch I cant select anymore the item in the drop down what browser did you use?

@yashop7
Copy link
Contributor Author
yashop7 commented Jun 27, 2025

the issue was that onblur get's triggered before onclick, that's why when we click some option on the dropdown, in meantime onblur removes the focus so option selected wasn't reflected, so now I added a delay in onblur, now it's working fine, In my case earlier onclick was triggering before onblur, so it was working fine for me

@dangershony dangershony merged commit d322e8a into block-core:main Jun 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0