10000 New UI for Investor to provide clarity at the time of Investing by yashop7 · Pull Request #435 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New UI for Investor to provide clarity at the time of Investing #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025

Conversation

yashop7
Copy link
Contributor
@yashop7 yashop7 commented Jun 19, 2025

BEFORE:

Screenshot 2025-06-19 at 6 20 33 PM Screenshot 2025-06-19 at 6 20 53 PM

AFTER:

Screenshot 2025-06-19 at 6 14 36 PM Screenshot 2025-06-19 at 6 15 10 PM

Mobile View

Screenshot 2025-06-19 at 6 17 58 PM Screenshot 2025-06-19 at 6 18 20 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this icon i smaller then the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed removing this SVG in the last commit, not using this anywhere in the code

@@ -626,6 +745,52 @@ else
{
await RefreshSignatures();
}
RefreshWizardState();
Copy link
Member
@dangershony dangershony Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this methods should go inside the if above no?

@@ -645,6 +810,51 @@ else
passwordComponent.ShowPassword(ScanForPendingSignatures);
}
}
RefreshWizardState();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this 3 methods are called twice once here and once in the render

@dangershony
Copy link
Member

image

@dangershony
Copy link
Member

The text is too light grey
image

@dangershony
Copy link
Member

Where does this text come from?
image

@dangershony
Copy link
Member

perhaps the text box on the popup should say "request to invest" or "send request"
image

@yashop7
Copy link
Contributor Author
yashop7 commented Jun 23, 2025

Where does this text come from? image

I can remove this If you say or replace it with something else, this was just to balance out with the left side, now there is much empty space in the right side
Screenshot 2025-06-23 at 11 20 21 PM

@yashop7
Copy link
Contributor Author
yashop7 commented Jun 23, 2025

image

Hi Dan, you tell me which browser you are using? I tried this on Safari & Chrome, looking fine on my side
Screenshot 2025-06-23 at 11 29 21 PM

</div>
}
<p class="agreement-text text-center">
By investing, you agree to the project terms and recovery agreement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just remove this text, a user may get confused and wonder where re those project terms?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or you can put there the penalty days that a user will wait if they bail out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Dan, Noted!

ED48
}

private async Task ScanforProjectStats()
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to call the indexer every time? it seems to me that once we call it then we don't need to do it again? we already have the stats.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I called the Indexer to get the TotalRaised amount, which is used to show the % in the progress bar, the other time it is called is to know if the investor is already invested at the time of investing
Screenshot 2025-06-25 at 8 45 18 PM

@@ -1090,6 +1300,7 @@ else
investorProject.CompleteProjectInvestment(signedTransaction.Transaction);

storage.UpdateInvestmentProject(investorProject);
invested = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to change the page view but then we anyway redirect way so it is a bit pointless

@@ -607,7 +607,7 @@ else
</button>
</div>
<p class="agreement-text text-center">
By investing, you agree to the project terms and recovery agreement
By investing, you acknowledge that early withdrawal requires a @project.ProjectInfo.PenaltyDays day waiting period
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@@ -1228,6 +1228,7 @@ else
if (res.ProjectIdentifier == investorProject.SignaturesInfo?.ProjectIdentifier)
{
investorProject.SignaturesInfo.Signatures = res.Signatures;
RefreshWizardState();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more change this is not a wizard it is a progress

@dangershony
Copy link
Member

I wonder now why do we have two cards that say waiting for signatures?

image

@dangershony dangershony merged commit e96aa1e into block-core:main Jun 25, 2025
3 checks passed
@yashop7
Copy link
Contributor Author
yashop7 commented Jun 25, 2025

I have made a planka card for this issue, will make a separate PR for this 👍

@yashop7 yashop7 deleted the new-investment-ui branch June 25, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0