-
Notifications
You must be signed in to change notification settings - Fork 33
New UI for Investor to provide clarity at the time of Investing #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems this icon i smaller then the others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed removing this SVG in the last commit, not using this anywhere in the code
src/Angor/Client/Pages/Invest.razor
Outdated
@@ -626,6 +745,52 @@ else | |||
{ | |||
await RefreshSignatures(); | |||
} | |||
RefreshWizardState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this methods should go inside the if above no?
src/Angor/Client/Pages/Invest.razor
Outdated
@@ -645,6 +810,51 @@ else | |||
passwordComponent.ShowPassword(ScanForPendingSignatures); | |||
} | |||
} | |||
RefreshWizardState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this 3 methods are called twice once here and once in the render
src/Angor/Client/Pages/Invest.razor
Outdated
</div> | ||
} | ||
<p class="agreement-text text-center"> | ||
By investing, you agree to the project terms and recovery agreement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just remove this text, a user may get confused and wonder where re those project terms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or you can put there the penalty days that a user will wait if they bail out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK Dan, Noted!
} | ||
|
||
private async Task ScanforProjectStats() | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to call the indexer every time? it seems to me that once we call it then we don't need to do it again? we already have the stats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Angor/Client/Pages/Invest.razor
Outdated
@@ -1090,6 +1300,7 @@ else | |||
investorProject.CompleteProjectInvestment(signedTransaction.Transaction); | |||
|
|||
storage.UpdateInvestmentProject(investorProject); | |||
invested = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to change the page view but then we anyway redirect way so it is a bit pointless
@@ -607,7 +607,7 @@ else | |||
</button> | |||
</div> | |||
<p class="agreement-text text-center"> | |||
By investing, you agree to the project terms and recovery agreement | |||
By investing, you acknowledge that early withdrawal requires a @project.ProjectInfo.PenaltyDays day waiting period |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
@@ -1228,6 +1228,7 @@ else | |||
if (res.ProjectIdentifier == investorProject.SignaturesInfo?.ProjectIdentifier) | |||
{ | |||
investorProject.SignaturesInfo.Signatures = res.Signatures; | |||
RefreshWizardState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more change this is not a wizard it is a progress
I have made a planka card for this issue, will make a separate PR for this 👍 |
BEFORE:
AFTER:
Mobile View