8000 Upgrade to nbitcoin 7.0.46 by dangershony · Pull Request #216 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to nbitcoin 7.0.46 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Upgrade to nbitcoin 7.0.46 #216

merged 2 commits into from
May 6, 2025

Conversation

dangershony
Copy link
Member

This is a draft till we are sure that we fixed all the issues with nbitcoin

@dangershony
Copy link
Member Author

This code was tested and I think we can now upgrade nbitcoin

@dangershony dangershony marked this pull request as ready for review May 5, 2025 14:57
Copy link
Member
@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and it looks alright, but I am not able to verify the changes fully as this requires a full test setup.

@dangershony
Copy link
Member Author

I reviewed the code and it looks alright, but I am not able to verify the changes fully as this requires a full test setup.

the code was tested end to end for create/invest/spend/penalty/recovery not tested was expire but the code is practically the same to penalty/recovery

@dangershony dangershony merged commit 76d2418 into main May 6, 2025
3 checks passed
@dangershony dangershony deleted the upgrade-nbitcoin-to-7-0-46 branch May 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0