Added Investor Link to angor indexer project page #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miladsoft , the button i have added is 👍 or 👎 |
miladsoft
reviewed
May 11, 2025
src/Angor/Client/Pages/View.razor
Outdated
| @@ -298,17 +298,22 @@ | |||
| </div> | |||
|
|
|||
| <div class="col-md-4"> | |||
| <a href="https://fulcrum.angor.online/angor/projects/@project.ProjectInfo.ProjectIdentifier" target="_blank" rel="noopener noreferrer"> | |||
There was a problem hiding this comment.
You should use a primary indexer, not a hardcoded address.
There was a problem hiding this comment.
Ok, I got the problem, does this Fix solve it?
dangershony
reviewed
May 12, 2025
src/Angor/Client/Pages/View.razor
Outdated
| </div> | ||
| <div class="stat-icon"> | ||
| <Icon IconName="users" Height="32" Width="32" /> | ||
| <a href="@($"{_NetworkService.GetPrimaryIndexer().Url}/angor/projects/{project.ProjectInfo.ProjectIdentifier}")" target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
it is not the indexer you want it is the explorer _NetworkService.GetPrimaryExplorer()
And please build the link itself in a method in the c# code
There was a problem hiding this comment.
Dan made the changes
dangershony
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added link to angor indexer project page to show list of investors in new tab
added noopener noreferrer for privacy
Before
After
