Improve create page #383
Merged
Improve create page #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd penalty days fields with improved labels and descriptions
…ate, and calculate expiry date automatically
…prove accessibility, and set automatic date handling for project stages
dangershony
reviewed
May 15, 2025
| public string NostrPubKey { get; set; } | ||
| public DateTime StartDate { get; set; } | ||
| public DateTime EndDate { get; set; } |
There was a problem hiding this comment.
This goes in the nostr event, we must be careful what params go in here
There was a problem hiding this comment.
We need to specify the end date of the fundraising. In previous discussions I asked if the first stage date meant the end date, which you said is not always the case.
There was a problem hiding this comment.
yes yes agree, but how does it work for existing projects?
WiIl it not break them?
There was a problem hiding this comment.
do we need to use the version upgrade I wonder?
There was a problem hiding this comment.
There is no problem for others. New projects specify the end date of the investment. In old projects, we define the start date of the stages as the end of the investment.
dangershony
previously approved these changes
May 15, 2025
…t, and clean up validation logic
…ht for NostrMetadataAbout section
dangershony
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.