8000 (FIX): Fixed the Founder Tab redirection error to Browse Tab on clcking on View Projects by ritankarsaha · Pull Request #391 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(FIX): Fixed the Founder Tab redirection error to Browse Tab on clcking on View Projects #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

ritankarsaha
Copy link
Contributor
@ritankarsaha ritankarsaha commented May 17, 2025

Issue

When a project under the Founders Tab is opened it gets automatically redirected to the Browse Tab. This PR fixes this issue

The issue is demonstrated in this video below --

Screencast.from.2025-05-17.17-06-39.webm

Proof of Work

Working Video --

updated.webm

This video shows that it does not get redirected to the Browse Tab. On clicking on a Project under the Founders Tab it displays the same behavior as opening a project from the Browse Tab does.

@miladsoft
Copy link
Member

What you did is wrong. You can fix it with just anifin the view page.

@miladsoft
Copy link
Member

image

@ritankarsaha
Copy link
Contributor Author

What you did is wrong. You can fix it with just anifin the view page.

Okaay fixing this and pushing a new commit @miladsoft !!

@ritankarsaha
Copy link
Contributor Author

Hey @miladsoft reverted back my changes in the NavMenu.razor file and applied the patch you suggested but it doesn't seem to work properly.

I have attached a recording for both my code changes and live app.

error.webm

@miladsoft
Copy link
Member

image

@miladsoft
Copy link
Member
protected override void OnParametersSet()
{
    base.OnParametersSet();
    
    // Update navigation state when parameters change
    if (founder)
    {
        NavMenuState.SetActivePage("founder");
    }
    else
    {
        NavMenuState.SetActivePage("browse");
    }
}

@ritankarsaha
Copy link
Contributor Author

image

Yes @miladsoft thankssss !! Works properly. Pushing in the commit !

@ritankarsaha
Copy link
Contributor Author

Pushed the new commit @miladsoft !!

Screencast.from.2025-05-18.13-11-10.webm

miladsoft
miladsoft previously approved these changes May 18, 2025
Copy link
Member
@miladsoft miladsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@@ -889,6 +890,20 @@
StateHasChanged();
}
}
protected override void OnParametersSet()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between methods

@@ -890,6 +891,21 @@
}
}

protected override void OnParametersSet()
{
base.OnParametersSet();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this code also in OnParametersSet?

@dangershony dangershony merged commit 7260c7b into block-core:main May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0