8000 Scan for how an investment was spent when recovering by dangershony · Pull Request #392 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Scan for how an investment was spent when recovering #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2025
Merged

Scan for how an investment was spent when recovering #392

merged 5 commits into from
Jun 2, 2025

Conversation

dangershony
Copy link
Member

No description provided.

@dangershony dangershony changed the title Prepare method to scan for how an investment was spent when recovering Scan for how an investment was spent when recovering May 20, 2025
DavidGershony
DavidGershony reviewed May 28, 2025
View reviewed changes
@DavidGershony DavidGershony self-requested a review May 28, 2025 14:26
DavidGershony
DavidGershony reviewed May 28, 2025
View reviewed changes
Copy link
Collaborator
@DavidGershony DavidGershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't have setting of booleans in the loop, better to just call the method in each case or just have default with false and only than not call it.

@dangershony dangershony merged commit 2da1874 into main Jun 2, 2025
3 checks passed
@dangershony dangershony deleted the scan-recovery-fix branch June 2, 2025 14:08
@dangershony
Copy link
Member Author
dangershony commented Jun 2, 2025 •
edited
Loading

How to test

  1. invest in a project
  2. take the first stage by the founder
  3. take the other two stages by the investor
  4. open the dev tools and take a copy of the projects json where the project details are set
  5. delete the investor wallet
  6. recover the investor wallet
  7. the json in the projects should look the same as the json in step 4
  8. take the funds out of penalty
  9. copy the json again
  10. delete and recover investors wallet
  11. check the json and it should look like the json in step 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGershony DavidGershony DavidGershony left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangershony @DavidGershony
0