Tags: blueconic/amphtml
Tags
Doubleclick lazy fetch (ampproject#28552) * Doubleclick lazy fetch support * Doubleclick lazy fetch support * review feedback Co-authored-by: Keith Wright <kjwright@kjwright-macbookpro4.roam.corp.google.com>
Allow empty analytics config switch from error to warning (ampproject… …#28536) * switch to warning * test
amp-animation documentation update (ampproject#28371) * updated structure and some wording * fixed links * Ff to If * actions * removed extra line * fixed nits * cleaned up example * fixed
Fix localization service retrieval. (ampproject#28440) Story navigation was completely blocked after prerendering the education screens, because somehow the `pointer-events: none;` was not respected and the `amp-story-education` element was acting as a click shield. Hiding it entirely works though, and does not change the animations. I've also seen race conditions where we try to access the ampdoc too early through the `getLocalizationService` method. To verify the fix: 1. Open the link in mobile emulation 2. In the console, copy/paste `AMP.viewer.receiveMessage('visibilitychange', {'state': 'visible'})` 3. Try to navigate to the next page [This story has the fix](https://stamp-storytime-le.firebaseapp.com/examples/s20/body-painting/index.html?amp_js_v=0.1#origin=https://www.google.com&prerenderSize=1&visibilityState=prerender&paddingTop=0&p2r=0&horizontalScrolling=0&csi=1&aoh=15526927198732&viewerUrl=https://www.google.com&history=1&storage=1&cid=1&cap=swipe,navigateTo,cid,fragment,replaceUrl,education) [This story should fail 80% of the time (no fix)](https://stamp-storytime-le-fail.firebaseapp.com/examples/s20/body-painting/index.html?amp_js_v=0.1#origin=https://www.google.com&prerenderSize=1&visibilityState=prerender&paddingTop=0&p2r=0&horizontalScrolling=0&csi=1&aoh=15526927198732&viewerUrl=https://www.google.com&history=1&storage=1&cid=1&cap=swipe,navigateTo,cid,fragment,replaceUrl,education) (cherry picked from commit 6f561cb)
Revert "🚮 Remove idleRenderOutsideViewport (ampproject#28043)" (amppr… …oject#28306) This reverts commit ab03e7c. (cherry picked from commit ceef8ee)
Fix localization service retrieval. (ampproject#28440) Story navigation was completely blocked after prerendering the education screens, because somehow the `pointer-events: none;` was not respected and the `amp-story-education` element was acting as a click shield. Hiding it entirely works though, and does not change the animations. I've also seen race conditions where we try to access the ampdoc too early through the `getLocalizationService` method. To verify the fix: 1. Open the link in mobile emulation 2. In the console, copy/paste `AMP.viewer.receiveMessage('visibilitychange', {'state': 'visible'})` 3. Try to navigate to the next page [This story has the fix](https://stamp-storytime-le.firebaseapp.com/examples/s20/body-painting/index.html?amp_js_v=0.1#origin=https://www.google.com&prerenderSize=1&visibilityState=prerender&paddingTop=0&p2r=0&horizontalScrolling=0&csi=1&aoh=15526927198732&viewerUrl=https://www.google.com&history=1&storage=1&cid=1&cap=swipe,navigateTo,cid,fragment,replaceUrl,education) [This story should fail 80% of the time (no fix)](https://stamp-storytime-le-fail.firebaseapp.com/examples/s20/body-painting/index.html?amp_js_v=0.1#origin=https://www.google.com&prerenderSize=1&visibilityState=prerender&paddingTop=0&p2r=0&horizontalScrolling=0&csi=1&aoh=15526927198732&viewerUrl=https://www.google.com&history=1&storage=1&cid=1&cap=swipe,navigateTo,cid,fragment,replaceUrl,education) (cherry picked from commit 6f561cb)
📦 Update dependency animate.css to v4.1.0 (ampproject#28324)
only wait for build for audio elements using nodisplay (ampproject#28407 ) (cherry picked from commit 655efdb)
only wait for build for audio elements using nodisplay (ampproject#28407 ) (cherry picked from commit 655efdb)
[amp-story-player] Fix import error (ampproject#28356) * fix cache error * add toolbox-cache-url js to sources * fix regex check * Revert "fix regex check" This reverts commit 6b2688e. (cherry picked from commit 2cbcf07)
PreviousNext