8000 Correctly validate unions with refs mapping to record types by essential-randomness · Pull Request #3864 · bluesky-social/atproto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Correctly validate unions with refs mapping to record types #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Correctly validate unions with refs mapping to record types #3864

wants to merge 2 commits into from

Conversation

essential-randomness
Copy link
@essential-randomness essential-randomness commented May 18, 2025 •
edited
Loading

According to the spec,record should be a valid type of ref in a union:

The schema definitions pointed to by a union are objects or types with a clear mapping to an object, like a record.

However, lexicon validation currently fails for record fields in union.

ValidationError: Unexpected lexicon type: record

This PR fixes the issue by adding validation for record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@essential-randomness
0