8000 fix: Should alway follow lockAspectRatio by AielloChan · Pull Request #759 · bokuweb/re-resizable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Should alway follow lockAspectRatio #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix: Should alway follow lockAspectRatio #759

merged 1 commit into from
Feb 24, 2022

Conversation

AielloChan
Copy link
Contributor

Move snap before calculateNewSizeFromAspectRatio, that keeps new width and height follow lockAspectRatio

Proposed solution

When set lockAspectRatio and snap, snap will break lockAspectRatio

Tradeoffs

None

Testing Done

Absolutely works

@AielloChan
fix: Should alway follow lockAspectRatio
acbe93d 
Move snap before calculateNewSizeFromAspectRatio, that keeps new width and height follow lockAspectRatio
bokuweb
bokuweb approved these changes Feb 24, 2022
View reviewed changes
Copy link
Owner
@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanaks for your great work, looks good

@bokuweb bokuweb merged commit 178784c into bokuweb:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bokuweb bokuweb bokuweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AielloChan @bokuweb
0