Allow setting existing secret name for TLS certs #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bokysan Is there any chance to have this added or something that would allow the controlling of the secret name |
|
Hey @mrskul, thank you for the commit. Seems almost OK, I've left a comment. If you can fix this, we can merge it. |
|
@bokysan Happy to fix this but i don't see the comment. |
bokysan
reviewed
May 28, 2025
helm/mail/templates/_helpers.tpl
Outdated
| {{- if $secretName -}} | ||
| {{- printf "%s" (tpl $secretName .) -}} | ||
| {{- else -}} | ||
| {{- printf "smtp-relay-mail-certs" -}} | 8000
There was a problem hiding this comment.
You have hardcoded a name here. Previously this was {{ $fullName }}-certs, but is now hardcoded. Please fix this.
| @@ -129,6 +129,8 @@ certs: | |||
| create: false | |||
| # Provide existing cert | |||
| existing: false | |||
| # Provide existing secret name | |||
| existingSecret: "" | |||
There was a problem hiding this comment.
I am missing:
- documentation (we should say something in
README.md) - tests (see https://github.com/bokysan/docker-postfix/tree/9fcd02f67ca753cb4c2fa06c44104b6d8a24c485/helm) -- tests are necessary to ensure that helm always generates proper YAML.
|
I'm sorry. My mistake - didn't click 'Finish review'. Should be visible now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be helpful to have a method for controlling the TLS secret name, as this would allow users to reference an existing secret and manage the name themselves. This is particularly useful when reflecting secrets from other namespaces, where renaming the secret may not be possible.