8000 GSoC20 Phase 1: Enhance CI workflows and switch to Github Actions by coder3101 · Pull Request #89 · boostorg/ublas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

GSoC20 Phase 1: Enhance CI workflows and switch to Github Actions #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2020
Merged

GSoC20 Phase 1: Enhance CI workflows and switch to Github Actions #89

merged 3 commits into from
Jul 11, 2020

Conversation

coder3101
Copy link
Contributor

More details of the work of this phase could be checked at my wiki https://github.com/BoostGSoC20/ublas/wiki

This PR introduces the following:

  • Use Github Actions as CI Service
  • Runs Units tests on a wide array of toolchains versions across all major OS
  • Adds Code Format checking and Clang tidy checking on CI
  • Add an Auto review script for PR
  • Increases code-coverage to 95% for only tensor module.
  • Adds Sanitizers to check for address and undefined behaviours

This PR removes the following:

  • OpenCL tests are not run
  • Remove .travis.yml
  • Remove .appveyor.yml

Requirements

  • Enable Github Actions from repository Settings for Github to actually enable CI for the repository.
  • Format the code as per .clang-tidy file
  • Fix the clang-tidy issues. (I will propose another PR as a fix)

Useful links:

@coder3101 coder3101 changed the title GSoC Phase 1: Enhance CI workflows and switch to Github Actions GSoC20 Phase 1: Enhance CI workflows and switch to Github Actions Jul 1, 2020
bassoy
bassoy requested changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator
@bassoy bassoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coder3101 I really like this pull request for using Github-Actions including many important checks using clang-tidy and clang-format. This will definitely elevate Boost.uBlas.

I request one change: Let's keep the appveyor and travis file for code except Boost.ublas.tensor and use Github-Actions for Boost.ublas.tensor.

@bassoy bassoy self-assigned this Jul 3, 2020
@coder3101
Tensor tests use Github Actions
b19cd5c 
Old uBLAS will only use Travis and Appveyor from old legacy CI while
Tensor is now build using modern Github Action on wide array of compiler
and standards and codes.
bassoy
bassoy approved these changes Jul 4, 2020
View reviewed changes
Copy link
Collaborator
@bassoy bassoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving the pull request.
@coder3101 would you like to add to the new created files a copyright with your name, see appveyor.yml ?

amitsingh19975
amitsingh19975 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator
@amitsingh19975 amitsingh19975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approving the changes.

@coder3101
Copy link
Contributor Author
coder3101 commented Jul 10, 2020 •
edited
Loading

If an active PR which has originated from this same repository for the develop branch is synchronized. CI will run every action twice (once for the push to feature/branch and another for pr to develop). This can be solved by filtering so that only master and develop triggers.

Benefits of this approach:

  • No twice build for actions in the above scenario.

Drawbacks:

  • For any features/branch to use Github actions all actions scripts will need to be modified (add features/branch to list for trigger branch).

My take is to keep things as is, We certainly don't want normal code PR to have changes in GitHub action scripts.

I declare this PR finalized;

@bassoy bassoy merged commit 0584e2a into boostorg:develop Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassoy bassoy bassoy approved these changes

@amitsingh19975 amitsingh19975 amitsingh19975 approved these changes

@stefanseefeld stefanseefeld Awaiting requested review from stefanseefeld

@yimyom yimyom Awaiting requested review from yimyom

Assignees

@bassoy bassoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coder3101 @bassoy @amitsingh19975
0