Introducing a new and versatile way to create the tensor interface. #90

amitsingh19975 · 2020-07-08T11:32:04Z

Previously the tensor was constraints to three type of tensors

Dynamic tensor
Static tensor
Fixed rank tensor
which were predefined and were written in stone or has a rigid interface and the user cannot change the storage type or permute the settings.

With the new tensor interface, we can easily new tensor type even custom storage by the user with proper configuration and easily interact with the current tensor environment without any hassle. This makes the new tensor interface very flexible.

There are few downsides right now

Had to remove static tensor tests because we introduced new constraints to the interface but it will be fixed in the next pull request which will be all about proper static tensor integration.
For a similar reason had to remove a few tests from the fixed rank tensors and will be fixed with the next pull request.

How to Use the New Interface

/// creates the engine traits with extents and strides with dynamic property with the static storage
using ctype1 = tensor_engine<extents<>, layout::first_order<>, std::array<float,50>>;

/// creates the engine traits with extents  with dynamic property and strides  with static property with the static storage
using ctype2 = tensor_engine<extents<>, layout::first_order<static_extents<1,2,3,4>>, std::array<float,50>>;

/// creates the engine traits with extents and strides with static property with the dynamic storage
using ctype3 = tensor_engine<layout::first_order<static_extents<1,2,3,4>>, std::vector<float>>;

using ttype1 = tensor_core<ctype1>;
using ttype2 = tensor_core<ctype2>;
using ttype3 = tensor_core<ctype3>;

auto t1 = ttype1{extents<>{1,2,3},1.f};
auto t2 = ttype2{extents<>{1,2,3,4},1.f};
auto t3 = ttype3{1.f};

Other than these there are a few minor tweaks to improve the consistency of the code and bug fixes.

…uration

coder3101 · 2020-07-11T17:18:15Z

@amitsingh19975 Would you please sync with current development branch and resolve the conflicts.

amitsingh19975 · 2020-07-11T17:37:39Z

@amitsingh19975 Would you please sync with current development branch and resolve the conflicts.

Sorry about that I cloned the branch before the new pull request. Now I have synced it. Thanks.

github-actions

Reports by clang tidy

examples/tensor/fixed_rank_tensor.cpp

include/boost/numeric/ublas/tensor/fixed_rank_extents.hpp

include/boost/numeric/ublas/tensor/functions.hpp

include/boost/numeric/ublas/tensor/static_strides.hpp

include/boost/numeric/ublas/tensor/tensor_core.hpp

github-actions · 2020-07-11T18:19:00Z

This Pull request Passed all of clang-tidy tests. 👍

codecov · 2020-07-11T18:32:25Z

Codecov Report

Merging #90 into develop will decrease coverage by 0.79%.
The diff coverage is 95.41%.

@@             Coverage Diff             @@
##           develop      #90      +/-   ##
===========================================
- Coverage    95.33%   94.54%   -0.80%     
===========================================
  Files           22       19       -3     
  Lines         1223     1192      -31     
===========================================
- Hits          1166     1127      -39     
- Misses          57       65       +8

Impacted Files	Coverage Δ
include/boost/numeric/ublas/tensor/multi_index.hpp	`100.00% <ø> (ø)`
...lude/boost/numeric/ublas/tensor/multiplication.hpp	`85.83% <ø> (-0.84%)`	⬇️
.../boost/numeric/ublas/tensor/fixed_rank_strides.hpp	`94.28% <85.71%> (-0.96%)`	⬇️
...ude/boost/numeric/ublas/tensor/dynamic_strides.hpp	`94.59% <86.66%> (-0.76%)`	⬇️
.../boost/numeric/ublas/tensor/fixed_rank_extents.hpp	`96.15% <92.85%> (+1.86%)`	⬆️
include/boost/numeric/ublas/tensor/tensor_core.hpp	`93.18% <93.18%> (ø)`
include/boost/numeric/ublas/tensor/functions.hpp	`94.94% <98.33%> (+0.26%)`	⬆️
include/boost/numeric/ublas/tensor/algorithms.hpp	`99.09% <100.00%> (ø)`
...ude/boost/numeric/ublas/tensor/dynamic_extents.hpp	`100.00% <100.00%> (+2.32%)`	⬆️
include/boost/numeric/ublas/tensor/expression.hpp	`100.00% <100.00%> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92177ce...580bae1. Read the comment docs.

github-actions

Reports by clang tidy

include/boost/numeric/ublas/tensor/tensor_core.hpp

github-actions

Reports by clang tidy

include/boost/numeric/ublas/tensor/tensor_core.hpp

bassoy

I still cannot approve due to rebind_storage_t usage.

include/boost/numeric/ublas/tensor/dynamic_strides.hpp

bassoy · 2020-08-18T19:37:09Z

include/boost/numeric/ublas/tensor/functions.hpp

+                layout::first_order<c_extents_type>,
+                layout::last_order<c_extents_type>
+            >,
+            rebind_storage_t<c_extents_type,array_type,value_type>


Let me phrase it differently. With rebind_storage_t the resulting storage type depends on the input storage type. In this case, the user of the library needs to look into type_traits_tensor.hpp for understanding the output type. Moreover, if the user wants to only have statically allocated containers, this rule forces him/her to not use the prod function or to change the implementation of rebind_storage_t.

Therefore, we should not to have that feature (at least for now) and at most use tag dispatching. Again the prod function with that signature should only be implemented for containers with dynamic extents and strides.

…ducts

…ts_functions.hpp with function implementation

.github/workflows/clangtidy_check.yml

github-actions

Reports by clang tidy

include/boost/numeric/ublas/tensor/static_strides.hpp

…nstexpr

bassoy

Great enhancements!
Only two comments which you can find in the corresponding files.
Please change the valid function to is_valid to be consistent with the naming.

include/boost/numeric/ublas/tensor/functions.hpp

include/boost/numeric/ublas/tensor/tensor.hpp

…ctions

amitsingh19975 · 2020-10-03T16:46:17Z

Great enhancements!
Only two comments which you can find in the corresponding files.
Please change the valid function to is_valid to be consistent with the naming.

Changed valid to is_valid.

bassoy

I think I have three remaining comments. Please look at them and see if there is something you would like to change. Otherwise I approve this.

include/boost/numeric/ublas/tensor/tensor_engine.hpp

include/boost/numeric/ublas/tensor/functions.hpp

amitsingh19975 added 3 commits June 22, 2020 17:04

improving the tensor design using tensor engine to support any config…

f751e7a

…uration

fixing and refactoring extents and strides

f8c37a8

making extents and strides class declarations contestants

3f74589

amitsingh19975 added the enhancement label Jul 8, 2020

amitsingh19975 assigned stefanseefeld, yimyom and bassoy Jul 8, 2020

Merge branch 'features/tensor_redesign' into develop

914fc69

amitsingh19975 requested a review from bassoy July 8, 2020 13:33

amitsingh19975 assigned amitsingh19975 and unassigned stefanseefeld, yimyom, bassoy and amitsingh19975 Jul 8, 2020

amitsingh19975 added 2 commits July 11, 2020 23:00

syncing with develop branch

33efb2c

syncing with develop branch

f637d45

amitsingh19975 added 2 commits July 11, 2020 23:23

fixing examples

ea85ed2

fixing type aliasing bug

c6ee5b1

github-actions bot reviewed Jul 11, 2020

View reviewed changes

fixing clang-tidy errors

850f836

github-actions bot reviewed Jul 11, 2020

View reviewed changes

include/boost/numeric/ublas/tensor/tensor_core.hpp Show resolved Hide resolved

adding move assignment operator

4951a44

github-actions bot reviewed Jul 11, 2020

View reviewed changes

include/boost/numeric/ublas/tensor/tensor_core.hpp Outdated Show resolved Hide resolved

amitsingh19975 force-pushed the features/tensor_redesign branch from 32e1e24 to 8afd714 Compare August 17, 2020 10:30

Merge branch 'develop' into features/tensor_redesign

3ffcaec

bassoy requested changes Aug 18, 2020

View reviewed changes

amitsingh19975 added 2 commits August 19, 2020 14:23

removing rebind_storage and adding rebind_storage_size for static pro…

9e3b418

…ducts

removing rebind_storage and adding rebind_storage_size for static pro…

f663678

…ducts

bassoy mentioned this pull request Sep 25, 2020

Crash in MSVC Debug mode caused by disabling of iterator debugging in vector_sparse.hpp #77

Open

amitsingh19975 added 2 commits October 2, 2020 01:30

refactoring directory and moving static_extents_traits.hpp into exten…

9255ef1

…ts_functions.hpp with function implementation

fixing github action

da91a80

amitsingh19975 force-pushed the features/tensor_redesign branch from ba351d5 to da91a80 Compare October 2, 2020 11:29

fixing msvc compiler bug

6d4b1e0

coder3101 reviewed Oct 2, 2020

View reviewed changes

.github/workflows/clangtidy_check.yml Show resolved Hide resolved

github-actions bot reviewed Oct 2, 2020

View reviewed changes

include/boost/numeric/ublas/tensor/static_strides.hpp Outdated Show resolved Hide resolved

amitsingh19975 force-pushed the features/tensor_redesign branch from 83521c0 to 75bae8f Compare October 2, 2020 12:06

refactoring make_static_strides code

9ffd554

amitsingh19975 force-pushed the features/tensor_redesign branch from 75bae8f to 9ffd554 Compare October 2, 2020 13:16

fixing: removing push_front and push_back in static_strides.hpp

80e161a

amitsingh19975 force-pushed the features/tensor_redesign branch from 11d159a to 80e161a Compare October 2, 2020 13:45

fix for msvc 14.27, it is unable to treat basic_static_extents::at co…

e2680d3

…nstexpr

amitsingh19975 force-pushed the features/tensor_redesign branch from 09fae55 to e2680d3 Compare October 2, 2020 14:48

bassoy requested changes Oct 3, 2020

View reviewed changes

include/boost/numeric/ublas/tensor/functions.hpp Outdated Show resolved Hide resolved

include/boost/numeric/ublas/tensor/functions.hpp Outdated Show resolved Hide resolved

include/boost/numeric/ublas/tensor/tensor.hpp Show resolved Hide resolved

amitsingh19975 added 2 commits October 3, 2020 20:54

changing name from valid to is_valid for naming consistency

1af1179

moving extents_result_type_* functions inside the respective prod fun…

e8af89a

…ctions

fixing broken license

2a1af28

bassoy approved these changes Oct 3, 2020

View reviewed changes

include/boost/numeric/ublas/tensor/tensor_engine.hpp Outdated Show resolved Hide resolved

include/boost/numeric/ublas/tensor/functions.hpp Outdated Show resolved Hide resolved

amitsingh19975 added 2 commits October 3, 2020 23:37

removing the unnecessary headers

c52707e

improving error and fixing error messages

580bae1

amitsingh19975 force-pushed the features/tensor_redesign branch from b91a78d to 580bae1 Compare October 5, 2020 09:22

bassoy approved these changes Oct 5, 2020

View reviewed changes

bassoy merged commit 799ef70 into develop Dec 10, 2020

Introducing a new and versatile way to create the tensor interface. #90

Introducing a new and versatile way to create the tensor interface. #90

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!