8000 Less `fs::metadata` call in `fn walk(` by ldm0 · Pull Request #481 · bootandy/dust · GitHub

More Web Proxy on the site http://driver.im/

Less `fs::metadata` call in `fn walk(` #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ldm0 wants to merge 1 commit into bootandy:master from ldm0:reduce_metadata

ldm0 commented

PathBuf::is_dir/PathBuf::is_file calls fs::metadata individually and can be squashed.


          Less fs::metadata call in walk

7b146b5

Owner

bootandy commented

I can see you've removed a call to fs::metadata here which is good.

But the extra code makes it slightly harder to read as well.

Testing with hyperfine, I can't see any performance improvement with this version so I suspect the call to fs::metadata is cached.

I'm not convinced this is worth adding as it doesn't seem to have a performance improvement.

Good idea though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0