8000 Set explicit doctrine/lexer version dependency by zanardigit · Pull Request #3526 · bolt/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set explicit doctrine/lexer version dependency #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set explicit doctrine/lexer version dependency #3526

wants to merge 1 commit into from

Conversation

zanardigit
Copy link

Bolt v5 is not compatible with doctrine/lexer v3 which introduces a breaking change: the token is now an object of class Doctrine\Common\Lexer\Token and not an array anymore. A normal composer update in a Bolt CMS based project may now generate an error: Cannot use object of type Doctrine\Common\Lexer\Token as array. The error goes away if doctrine/lexer v2 is explicitly required.

On a separate PR I will propose an actual fix. This is about setting the dependency in Bolt CMS own composer.json.

@zanardigit @bobvandevijver
Set explicit doctrine/lexer version dependency
e2c0a3d 
Bolt v5 is not compatible with doctrine/lexer v3 which introduces a breaking change.
@bobvandevijver
Copy link
Member
bobvandevijver commented Mar 6, 2025 •
edited
Loading

😞 I wanted to merge this, but one of the dev dependencies (coduo/php-matcher) requries doctrine/lexer v1. Would you be open to look into this?

(note that I rebased the branch to be able to run the updated actions)

@zanardigit
Copy link
Author

Let's see. I am already using the modified version successfully in PROD, as that conflict is on a DEV requirement, so I'd rather not revert back to doctrine/lexer v1. We could bump php-matcher to version 6 but is only compatible with PHP 8.1+, would that be ok?

@bobvandevijver
Copy link
Member

That depends on the outcome of this vote: #3538. It has been opened just yesterday (so I want to give it some time), but I expect we will be dropping 8.0 and older soon.

@bobvandevijver
Copy link
Member

This has been superseded by #3558, which has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanardigit @bobvandevijver
0