Add support of \DateTimeInterface in setContentFields #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @clem ! Thanks for opening this Pull Request. Is this working on your end? I think you are missing a use statement of the Carbon class. |
|
I think you're right, @nestordedios! I didn't copied the modified file, I just added the block and I totally forgot it! 😅 Thank you, I'll update it now! |
When a field has a `$value` typed as `\DateTimeInterface`, the string conversion at line 98 throws an error as this class does not have a `__toString()` method. Converting this `\DateTimeInterface` to `Carbon` fixes this issue.
nestordedios
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a field has a
$valuetyped as\DateTimeInterface, the string conversion at line 98 throws an error as this class does not have a__toString()method. Converting this\DateTimeInterfacetoCarbonfixes this issue.