8000 Swap `Offer` and `Choose` generic parameter order. by yaymukund · Pull Request #122 · boltlabs-inc/dialectic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Swap Offer and Choose generic parameter order. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

Swap Offer and Choose generic parameter order. #122

merged 1 commit into from
Dec 1, 2021

Conversation

yaymukund
Copy link

Does what it says :)

@yaymukund yaymukund requested a review from plaidfinch November 2, 2021 00:35
plaidfinch
plaidfinch approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor
@plaidfinch plaidfinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Clean, simple, does what it says on the tin :)

@yaymukund yaymukund merged commit 6b5f6ae into carrier-type Dec 1, 2021
@yaymukund yaymukund deleted the carrier-type-swap-offer-choose branch December 1, 2021 17:08
@yaymukund yaymukund mentioned this pull request Dec 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaidfinch plaidfinch plaidfinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaymukund @plaidfinch
0