8000 Improve `err` checking, ensure working isolated by bombsimon · Pull Request #179 · bombsimon/wsl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve err checking, ensure working isolated #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Improve err checking, ensure working isolated #179

merged 1 commit into from
Jun 24, 2025

Conversation

bombsimon
Copy link
Owner
  • Always run err checking even if if is disabled
  • Don't force cuddling if no errors are checked
  • Don't force cuddling if no variables intersect
  • Only check cuddling if previous node is assign or decl
  • Move test to default testing

Closes #177

@bombsimon
Improve err checking, ensure working isolated
0ac23d2 
- Always run `err` checking even if `if` is disabled
- Don't force cuddling if no errors are checked
- Don't force cuddling if no variables intersect
- Only check cuddling if previous node is assign or decl
- Move test to default testing
@coveralls
Copy link

Coverage Status

coverage: 93.444% (-1.0%) from 94.492%
when pulling 0ac23d2 on fix-err-checking
into 7329c34 on main.

@bombsimon bombsimon merged commit 4ab9357 into main Jun 24, 2025
4 checks passed
@bombsimon bombsimon deleted the fix-err-checking branch June 24, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error checking does not work isolated
2 participants
@bombsimon @coveralls
0