Make error check 8000 ing more laxed #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only perform error checking when there's a single comparison with a
binary operator comparing an error with `nil`. Both `!=` and `==` are
candidates for cuddling.
These should be cuddled if `err` exist on the line above
```go
if err != nil {}
if err == nil {}
```
Nothing else should trigger this lint, all of these should be left
```go
// More than error checking
if err != nil || true {}
// Technically an error checking, but we only check for binary
// operators, not expressions.
if errors.Is(err, SomeErr) {}
// More than one error checking
if err != nil || err2 != nil {}
```
This also matches [`gofumpt`](https://github.com/mvdan/gofumpt) which
has this rule:
> No empty lines before a simple error check
>
> ```go
> foo, err := processFoo()
>
> if err != nil {
> return err
> }
> ```
>
> ```go
> foo, err := processFoo()
> if err != nil {
> return err
> }
> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only perform error checking when there's a single comparison with a binary operator comparing an error with
nil. Both!=and==are candidates for cuddling.These should be cuddled if
errexist on the line aboveNothing else should trigger this lint, all of these should be left
This also matches
gofumptwhich has this rule:Solves #183