8000 refactor: pass file arguments as stream readers/writers instead of strings by jhoward-lm · Pull Request #76 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: pass file arguments as stream readers/writers instead of strings #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2024
Merged

refactor: pass file arguments as stream readers/writers instead of strings #76

merged 3 commits into from
Jun 11, 2024

Conversation

jhoward-lm
Copy link
Contributor

Pass file arguments as stream readers/writers instead of strings

Description

Type of change

Please delete options that are not relevant.

  • Refactor

How Has This Been Tested?

  • Local testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm
refactor: pass file arguments as stream readers/writers instead of st…
2894259 
…rings

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm requested a review from a team as a code owner June 11, 2024 14:32
@jhoward-lm jhoward-lm self-assigned this Jun 11, 2024
ashearin
ashearin requested changes Jun 11, 2024
View reviewed changes
@jhoward-lm
chore: address PR comment
c910bda 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
fix: limit input SBOM URLs to a single argument when --output-file is…
192b969 
… used

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm merged commit 61a6731 into main Jun 11, 2024
7 checks passed
@jhow 86F2 ard-lm jhoward-lm deleted the file-parameters branch June 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idunbarh idunbarh idunbarh approved these changes

@ashearin ashearin ashearin approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels
None yet
Projects
bomctl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhoward-lm @ashearin @idunbarh
0