10000 refactor: remove globals, use functional options pattern by jhoward-lm · Pull Request #77 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove globals, use fu 8000 nctional options pattern #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

refactor: remove globals, use functional options pattern #77

merged 1 commit into from
Jun 11, 2024

Conversation

jhoward-lm
Copy link
Contributor

Remove globals, use functional options pattern

Description

  • Enable gochecknoglobals config for golangci-lint
  • Remove global variables
  • Pass options as structs instead of as parameters directly with functional option pattern support

Type of change

  • Refactor

How Has This Been Tested?

  • Local testing
  • Workflow

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm
refactor: remove globals, use functional options pattern
8000
a703607 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm added the enhancement New feature or request label Jun 11, 2024
@jhoward-lm jhoward-lm self-assigned this Jun 11, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner June 11, 2024 18:18
@idunbarh idunbarh merged commit 72b7a56 into main Jun 11, 2024
7 checks passed
@idunbarh idunbarh deleted the functional-options branch June 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels
enhancement New feature or request
Projects
bomctl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhoward-lm @ashearin @idunbarh
0