8000 refactor: stage all externally referenced SBOMs before push by jhoward-lm · Pull Request #155 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: stage all externally referenced SBOMs before push #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 19, 2024
Merged

refactor: stage all externally referenced SBOMs before push #155

merged 10 commits into from
Sep 19, 2024

Conversation

jhoward-lm
Copy link
Contributor

Description

This PR updates the Client interface to allow push operations to:

  • Prepare a "staging area" for the full SBOM external reference graph
  • Recursively add all externally referenced SBOMs to this staging area
  • Do a single push operation containing all staged SBOMs

It also updates the existing Git push operation to use this pattern.

Depends on #153 being merged first (comparison of changes)

Fixes #154

Type of change

  • Refactor/enhancement

How Has This Been Tested?

  • Stand up temporary Git server for testing push, pull, and clone

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm
feat: document annotations for source data, hash, format, and URL
48e390f 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
fix: set Git config for push test
ea5f020 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
8000
@jhoward-lm
refactor: add client interface methods to allow pushing multiple file…
973569a 
…s at once

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
test: add httptest Git server for testing remote Git operations
da82eff 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm added the enhancement New feature or request label Sep 13, 2024
@jhoward-lm jhoward-lm self-assigned this Sep 13, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner September 13, 2024 20:42
@jhoward-lm jhoward-lm linked an issue Sep 13, 2024 that may be closed by this pull request
Stage all externally referenced SBOMs before push #154
Closed
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into 68-exten…
db48f7f 
…ded-ent-schemas
@jhoward-lm
Merge branch '68-extended-ent-schemas' of https://github.com/bomctl/b…
d4e4dd3 
…omctl into 154-client-prepare-push

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into 154-clie…
0051abf 
…nt-prepare-push

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into 154-clie…
da21075 
…nt-prepare-push
@jhoward-lm
refactor: scoped test suites
9ce506e 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm merged commit 40130aa into main Sep 19, 2024
9 checks passed
@jhoward-lm jhoward-lm deleted the 154-client-prepare-push branch September 19, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@lmphil lmphil lmphil approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels
enhancement New feature or request
Projects
bomctl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stage all externally referenced SBOMs before push
4 participants
@jhoward-lm @ashearin @idunbarh @lmphil
0