8000 test: integration testing of functionality by ashearin · Pull Request #169 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: integration testing of functionality #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 7, 2024
Merged

test: integration testing of functionality #169

merged 7 commits into from
Oct 7, 2024

Conversation

ashearin
Copy link
Member
@ashearin ashearin commented Sep 20, 2024 •
edited
Loading

Description

Adding e2e tests using testscript package.

There are commented out tests/lines in different files for failures that weren't expected and were not a quick fix. I attempted to record the failure reason, so if you have more context on a failure or know how to fix the issue please lmk. Otherwise a follow on issue will be created for each.

Also made an update to the way the root cmd is called, as it was needed for this test package.

These tests can be run as part of the general 'go test' cmd, but I added tasks in the task file and Makefile to run only the e2e and unit tests.

Fixes #121

References (More info on testscript)

@ashearin ashearin self-assigned this Sep 20, 2024
@ashearin ashearin requested a review from a team as a code owner September 20, 2024 20:36
@ashearin ashearin linked an issue Sep 20, 2024 that may be closed by this pull request
Intergration testing of functionality #121
Closed
@ashearin ashearin marked this pull request as draft September 20, 2024 20:36
@ashearin ashearin changed the title Draft: integration testing of functionality feat: integration testing of functionality Sep 20, 2024
idunbarh
idunbarh reviewed Sep 24, 2024
View reviewed changes
@ashearin ashearin force-pushed the 121-intergration-testing-of-functionality branch from 7cf0605 to 8470f22 Compare September 25, 2024 19:30
@ashearin ashearin marked this pull request as ready for review October 1, 2024 18:38
@ashearin ashearin force-pushed the 121-intergration-testing-of-functionality branch from 09a753b to cf43a8e Compare October 2, 2024 01:14
idunbarh
idunbarh approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member
@idunbarh idunbarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is a really great addition to the project. Thanks for putting this together!

@ashearin ashearin force-pushed the 121-intergration-testing-of-functionality branch from cf43a8e to f82991f Compare October 2, 2024 14:47
ashearin commented Oct 2, 2024
View reviewed changes
@ashearin ashearin changed the title feat: integration testing of functionality test: integration testing of functionality Oct 2, 2024
@jhoward-lm
Copy link
Contributor
jhoward-lm commented Oct 2, 2024 •
edited
Loading

For the revive confusing-naming linter issue, I think it's ok to add the following to .golangci.yml under linter-settings:revive:rules:

      - name: confusing-naming
        exclude: [TEST]

Unless you'd prefer to just rename the method in internal/pkg/client/oci/internal_test.go to something like CreateTestRepo or whatever sounds good

@ashearin ashearin force-pushed the 121-intergration-testing-of-functionality branch from b59dcbc to 5078ac6 Compare October 2, 2024 21:43
jhoward-lm
jhoward-lm approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor
@jhoward-lm jhoward-lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ashearin ashearin merged commit e0d0c9e into main Oct 7, 2024
7 checks passed
@ashearin ashearin deleted the 121-intergration-testing-of-functionality branch October 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idunbarh idunbarh idunbarh approved these changes

@lmphil lmphil lmphil approved these changes

@jhoward-lm jhoward-lm jhoward-lm approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@ashearin ashearin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intergration testing of functionality
4 participants
@ashearin @jhoward-lm @idunbarh @lmphil
0