8000 docs: fix typo in MAINTAINERS.md by evankanderson · Pull Request #180 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix typo in 8000 MAINTAINERS.md #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2024
Merged

docs: fix typo in MAINTAINERS.md #180

merged 2 commits into from
Oct 7, 2024

Conversation

evankanderson
Copy link
Contributor

Description

I was reading the MAINTAINERS.md, and I noticed a repeated word.

Type of change

Governance "change" (cleanup).

How Has This Been Tested?

Not at all.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@evankanderson evankanderson requested a review from a team as a code owner October 4, 2024 15:47
@evankanderson evankanderson changed the title Fix typo in MAINTAINERS fix: Fix typo in MAINTAINERS Oct 4, 2024
@evankanderson evankanderson changed the title fix: Fix typo in MAINTAINERS Fix typo in MAINTAINERS Oct 4, 2024
@jhoward-lm jhoward-lm changed the title Fix typo in MAINTAINERS docs: fix typo in MAINTAINERS.md Oct 4, 2024
@jhoward-lm
Copy link
Contributor

@evankanderson I updated the title of the PR to a conventional commit so that changelog generation works correctly. Thanks for fixing the typo!

@ashearin
Copy link
Member
ashearin commented Oct 7, 2024

@evankanderson Looks like your initial commit was unsigned, which is required to get it merged. Are you able to squash and recommit with a signature?

@evankanderson evankanderson force-pushed the main branch 2 times, most recently from d02a19f to 1efab50 Compare October 7, 2024 19:22
@evankanderson
Copy link
Contributor Author

Done, and I added a note to CONTRIBUTING.md to indicate that commits need to be signed, since I didn't see it in the directions.

@evankanderson
fix: Fix typo in MAINTAINERS
42a85e6 
Signed-off-by: Evan Anderson <evan@stacklok.com>
@evankanderson
Copy link
Contributor Author

Oh, and I also updated the CONTRIBUTING.md instructions to highlight that the PR title needs to match conventional commits, not just the commit messages.

idunbarh
idunbarh approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member
@idunbarh idunbarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @evankanderson!

@idunbarh idunbarh merged commit 5ff902a into bomctl:main Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@jhoward-lm jhoward-lm jhoward-lm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evankanderson @jhoward-lm @ashearin @idunbarh
0