8000 fix: update compare_docs function by ashearin · Pull Request #202 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: update compare_docs function #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix: update compare_docs function #202

merged 4 commits into from
Nov 5, 2024

Conversation

ashearin
Copy link
Member
@ashearin ashearin commented Nov 5, 2024 •
edited
Loading

Description

Updates compare_docs test function to properly check metadata values and account for cyclonedx properties being lost so the hash values dont match. AKA update compare docs to do a soft compare, making sure that no nodes were lost and the names match

Fixes #178

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Tests
  • e2e tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ashearin ashearin self-assigned this Nov 5, 2024
@ashearin ashearin requested a review from a team as a code owner November 5, 2024 17:47
@stacklok-cloud
Copy link
stacklok-cloud bot commented Nov 5, 2024

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 6dd37265:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

idunbarh
idunbarh approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member
@idunbarh idunbarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending @jhoward-lm's comments, it looks good

jhoward-lm
jhoward-lm approved these changes Nov 5, 2024
View reviewed changes
@ashearin @jhoward-lm
Apply suggestions from code review
37a4a6d 
apply casing adjustments

Co-authored-by: jhoward-lm <140011346+jhoward-lm@users.noreply.github.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
@ashearin ashearin merged commit 539eaad into bomctl:main Nov 5, 2024
7 checks passed
@ashearin ashearin deleted the 178-bug-fix-spdx-metadata-equality-issue-seen-in-e2e-tests branch November 5, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoward-lm jhoward-lm jhoward-lm approved these changes

@idunbarh idunbarh idunbarh approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@lmphil lmphil Awaiting requested review from lmphil

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@ashearin ashearin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Fix spdx Metadata Equality issue seen in e2e tests
3 participants
@ashearin @idunbarh @jhoward-lm
0