8000 feat: github client fetch support by lallevato-lm · Pull Request #209 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: github client fetch support #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 21, 2024

Conversation

lallevato-lm
Copy link
Contributor
@lallevato-lm lallevato-lm commented Nov 13, 2024

Description

This change includes a client for Github with fetch functionality. For this client, bomctl fetch will retrieve the dependency graph sbom for the default commit of the specified repository. Currently Github does not support retrieving dependency graphs for other branches, commits, or releases.

Example usage:

bomctl fetch https://github.com/bomctl/bomctl --netrc

This command will fetch the dependency graph sbom for the bomctl repository.

Note: This change includes a push.go file for the Github client, but the file is basically an empty skeleton.

For context, see #132

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
@lallevato-lm lallevato-lm requested a review from a team as a code owner November 13, 2024 17:44
@stacklok-cloud
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 08540a3a:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

lallevato-lm and others added 2 commits November 13, 2024 10:48
Signed-off-by: Luke Allevato <165693161+lallevato-lm@users.noreply.github.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
@ashearin ashearin changed the title Github client support feat: Github client support Nov 13, 2024
@lallevato-lm lallevato-lm changed the title feat: Github client support feat: github client fetch support Nov 13, 2024
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
lallevato-lm and others added 5 commits November 13, 2024 12:43
Co-authored-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Luke Allevato <165693161+lallevato-lm@users.noreply.github.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
lallevato-lm and others added 4 commits November 14, 2024 10:53
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Co-authored-by: jhoward-lm <140011346+jhoward-lm@users.noreply.github.com>
Signed-off-by: Luke Allevato <165693161+lallevato-lm@users.noreply.github.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
lallevato-lm and others added 3 commits November 18, 2024 10:36
Good catch, thanks!

Co-authored-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Luke Allevato <165693161+lallevato-lm@users.noreply.github.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
Signed-off-by: lallevato-lm <luke.d.allevato@lmco.com>
@jhoward-lm jhoward-lm merged commit de7996f into bomctl:main Nov 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 4957 div class="discussion-sidebar-heading text-bold"> Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0