8000 feat: add link command stubs by jhoward-lm · Pull Request #222 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add link command stubs #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2024
Merged

feat: add link command stubs #222

merged 3 commits into from
Nov 23, 2024

Conversation

jhoward-lm
Copy link
Contributor

Description

This PR adds stubs for the link command and its subcommands.

Miscellaneous

  • Update protobom/storage dependency and refactor
  • Exclude cobra.*Args from mnd linter (magic number detection)

Closes #220

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm jhoward-lm self-assigned this Nov 21, 2024
@stacklok-cloud
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 231c2801:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@jhoward-lm jhoward-lm force-pushed the 220-create-link-command-skeleton branch from 231c280 to 80f6d9c Compare November 22, 2024 16:17
@jhoward-lm
chore: update protobom/storage dependency
18326c6 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
feat: link command stubs
f1a72d8 
chore:
- exclude `cobra.*Arg` from `mnd` linter and refactor

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
chore: add coverage report to task tests
56d3cfc 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm force-pushed the 220-create-link-command-skeleton branch from 80f6d9c to 56d3cfc Compare November 22, 2024 18:42
@jhoward-lm jhoward-lm marked this pull request as ready for review November 23, 2024 21:43
@jhoward-lm jhoward-lm requested a review from a team as a code owner November 23, 2024 21:43
@jhoward-lm jhoward-lm merged commit 1ec4c11 into bomctl:main Nov 23, 2024
7 checks passed
@jhoward-lm jhoward-lm deleted the 220-create-link-command-skeleton branch November 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@lmphil lmphil Awaiting requested review from lmphil

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create link command skeleton
3 participants
@jhoward-lm @ashearin @idunbarh
0