8000 refactor: add client PrepareFetch method by jhoward-lm · Pull Request #245 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: add client PrepareFetch method #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jhoward-lm
Copy link
Contributor

Description

This PR adds the PrepareFetch method to the Client interface definition. It also separates the concerns of fetching vs pushing by breaking out two new interfaces from the Client interface called Fetcher and Pusher.

Fixes #244

Type of change

  • Refactor

How Has This Been Tested?

  • Unit/e2e tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

…pareFetch method

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm self-assigned this Dec 17, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner December 17, 2024 17:12
@jhoward-lm jhoward-lm merged commit f98b267 into bomctl:main Dec 17, 2024
8 checks passed
@jhoward-lm jhoward-lm deleted the 244-add-client-preparefetch-method branch December 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Client PrepareFetch Method
4 participants
0