8000 Fix connecting with new paramiko version by bennofs · Pull Request #128 · bordaigorl/rmview · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix connecting with new paramiko version #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix connecting with new paramiko version #128

merged 1 commit into from
Jan 20, 2022

Conversation

bennofs
Copy link
Contributor
@bennofs bennofs commented Jan 18, 2022

Connecting to remarkable with 2.9 fails without this fix

@gustaphe
Copy link

Great timing! My problem in #127 disappeared when I downgraded paramiko to 2.8.1. I don't know if this PR works, but at least it correctly fingered paramiko 2.9 as the culprit.

@bordaigorl
Copy link
Owner

Thank you so much @bennofs it would have taken me ages to debug related issues!
@gustaphe it would be great if you could test this branch (you can checkout the code and pip install again)

@gustaphe
Copy link

I don't know python, so I'm uncertain if I'm testing the right thing, but

pip install --upgrade paramiko
pip install .
rmview -v

from inside this directory worked perfectly so I guess that's an LGTM from me.

@bordaigorl bordaigorl merged commit 9fadf38 into bordaigorl:vnc Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bennofs @gustaphe @bordaigorl
0