8000 Added Authentication to RedisStorage by flavioheleno · Pull Request #439 · botman/botman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added Authentication to RedisStorage #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2017
Merged

Added Authentication to RedisStorage #439

merged 2 commits into from
Jun 21, 2017

Conversation

flavioheleno
Copy link
Contributor

This is similar to what has been discussed on #432 but targeted to the Storage system.

Note: This PR requires changes to travis.yml made by #438 to be merged first (not sure how to handle it in a more clean way).

@codecov
Copy link
codecov bot commented Jun 21, 2017

Codecov Report

Merging #439 into 1.5 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               1.5     #439      +/-   ##
===========================================
+ Coverage     85.5%   85.53%   +0.02%     
- Complexity     805      806       +1     
===========================================
  Files           68       68              
  Lines         2284     2288       +4     
===========================================
+ Hits          1953     1957       +4     
  Misses         331      331
Impacted Files Coverage Δ Complexity Δ
...c/Mpociot/BotMan/Storages/Drivers/RedisStorage.php 85.36% <100%> (+1.58%) 15 <2> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0773cec...9874e1d. Read the comment docs.

@mpociot mpociot merged commit 70f9807 into botman:1.5 Jun 21, 2017
@flavioheleno flavioheleno deleted the redis-storage-auth branch June 28, 2017 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0