8000 Add RequestId to error message by tdriscoll · Pull Request #2605 · boto/botocore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add RequestId to error message #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tdriscoll
Copy link

This adds the RequestID to the error string. The RequestID is useful/required when raising tickets with AWS support.

It's possible to catch these errors and explicitly log the RequestID but that means handling exceptions for every API call. I believe it is also possible with DEBUG logging but that logs much more than errors.

My experience was that I went to report an error but did not have the foresight to log the request id. In addition, it was a difficult to reproduce error. This is why I like the idea of including the RequestID by default for errors.

I tried to keep to the style of the repo but let me know if you want me to clean anything up.

@kdaily
Copy link
Member
kdaily commented Feb 24, 2022

Thanks for the PR, @tdriscoll. I note that this would close this issue (you also requested, thanks!):

boto/boto3#1143

I don't have a timeline when this will get a review.

@tim-finnigan
Copy link
Contributor

Thanks for creating this PR. I brought it up for discussion with the team, and the consensus was that this should be closed as not planned. You can already get the Request ID from the ResponseMetadata without too much trouble. There is also documentation referenced here on logging the Request ID.

@tdriscoll
Copy link
Author

Understood. Thanks for taking the time to consider it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0