source: add pciclient crate for high level access to lspci #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f630bd2 to
b19ea44
Compare
yeazelm
reviewed
Sep 16, 2024
sources/pciclient/src/lib.rs
Outdated
Comment on lines
140
to
143
| use bon::Builder; | ||
| use derive_getters::Getters; | ||
| pub use error::PciClientError; | ||
| use private::{call_list_devices, check_efa_attachment, PciClient}; |
There was a problem hiding this comment.
nit: We usually include these at the top.
There was a problem hiding this comment.
I have moved the bon and derive_getters and private crate functions deps to top. Looks like for Error and Result related statements, we keep them after the definition of the Error mod. See https://github.com/bottlerocket-os/bottlerocket-core-kit/blob/develop/sources/api/storewolf/src/main.rs#L138-L141
Signed-off-by: Yutong Sun <yutongsu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
A
2F2E
dd this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added crate pciclient to provide a high level helper to query the PCI information and get the device information.
Testing done:
Unit tests.
More tests are done in #141 which uses the crate to call lspci and detect EFA.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.