kernel-6.1: fix kernel-devel requirement #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of Twoliter might not define either the positive or negative versions of the erofs image feature, which would result in neither of the kernel-devel subpackages getting installed. Fix this by always installing the squashed version unless the positive form of the erofs image feature is present. Signed-off-by: Ben Cressey < 8000 ;bcressey@amazon.com>
cbgbt
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Older versions of Twoliter might not define either the positive or negative versions of the erofs image feature, which would result in neither of the kernel-devel subpackages getting installed. Fix this by always installing the squashed version unless the positive form of the erofs image feature is present.
Testing done:
Built
aws-ecs-2with the released version of Twoliter 0.4.6, which does not support the erofs image feature.Before this change, it failed to build with this error:
After, the build completed. I confirmed that the "squashed" version was installed:
Using a local build of Twoliter which does support the erofs image feature, I confirmed that the "unpacked" version was installed after enabling the feature:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.