package updates: aws-iam-authenticator to 0.6.29 and aws-signing-helper to 1.4.0 #365
Conversation
There was a problem hiding this comment.
Changes LGTM, but a nit on the commit messages, where we prefer:
- packages: update aws-iam-authenticator to 0.6.29
- packages: update aws-signing-helper to 1.4.0
Also, let's update the PR title to mention we are updating aws-iam-authenticator and aws-signing-helper specifically for clarification
| @@ -49,7 +49,7 @@ Conflicts: (%{_cross_os}image-feature(no-fips) or %{name}-bin) | |||
|
|
|||
| %build | |||
| %set_cross_go_flags | |||
| export GO_MAJOR="1.22" | |||
| export GO_MAJOR="1.23" | |||
There was a problem hiding this comment.
Is this change strictly required to build? You are overriding the SDK default and it would be better to leave it alone if it's not required.
There was a problem hiding this comment.
In other words - I'd rather delete this line than change it.
There was a problem hiding this comment.
Sorry for the delay - I tired to build without changing the GO_MAJOR or delete this line but it won't build. I think the reason is they updated go version in v0.6.29.
https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.6.29#:~:text=3b3bf6f%20chore%3A%20Update%20to%20go%201.23.4
There was a problem hiding this comment.
Seems a similar issue in the past occured, the SDK was on 1.21:
bottlerocket-os/bottlerocket-sdk@acf1d65
And we moved this package to GO MAJOR 1.22:
0ee5cba
Which matches the go version on v0.6.21:
https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/v0.6.21/.go-version
I also confirmed the toolchain error on check-out.
LGTM
Description of changes:
Updated aws-iam-authenticator to 0.6.29, and aws-signing helper to 1.4.0
Testing done:
Quick tests and smoke tests passed.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.