feat: improve GetMulti method resilience and performance #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skip failed servers instead of returning early when PickServer fails - Pre-allocate result map with expected capacity to avoid dynamic resizing - Ensure partial results are returned even when some memcache servers are unavailable This change improves fault tolerance by allowing GetMulti to continue processing keys from healthy servers when some servers are down, while also optimizing memory allocation performance. Fixes issue where GetMulti would fail entirely if any single server was unreachable, now gracefully handles server failures and returns available data from functioning servers.
|
This change indeed improves the efficiency of batch cache data retrieval and provides better fault tolerance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a bat
2FF7
ch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves fault tolerance by allowing GetMulti to continue processing keys from healthy servers when some servers are down, while also optimizing memory allocation performance.
Fixes issue where GetMulti would fail entirely if any single server was unreachable, now gracefully handles server failures and returns available data from functioning servers.