Move to pyproject_toml + package cleanup #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I dropped setup.py completely. Moved to scikit-build-core and Cmake. This is in prerparation for trying cibuildwheel.
Seems like this dependency isn't needed. The hfta example in docs imports it but never uses it. It is giving us issues with Python 3.9 and MacOS because it depends on deepdish which depends on tables. Tables dropped 3.9 support.
Hope this fixes issues with finding library in cibuildwheel repair wheel.
Seems the MPI tests can be flakey.
For now, we just run tests, no pr-check. I think the next steps should be to get rid of pr-check.sh, run-checks.sh, and run-tests.sh and replace with actions.
|
Hey @mihaic , I think this one is ready, let me know what you think. della_notebooks run needs to be fixed. I will do another PR for it though. |
mihaic
approved these changes
Nov 15, 2024
This was referenced Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very large PR that began with a simple goal of moving the project over to pyproject TOML standard. Due to continued issues with failing CI jobs because of things like upper pins on old packages, dependencies on deprecated packages (theano), failing mpi tests, among other things; the PR became much more complicated. A rough list of improvements are the following:
I still think there is considerable work to be done in cleaning up the pr-check.sh, run-tests.sh, and run-checks.sh scripts. Probably better to move these to github actions workflows or something so we can run them on windows. Currently, windows checks are just running pytest.