8000 Fix release publish by davidt0x · Pull Request #552 · brainiak/brainiak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix release publish #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 4 commits into from
Nov 17, 2024
Merged

Fix release publish #552

merged 4 commits into from
Nov 17, 2024

Conversation

davidt0x
Copy link
Contributor
@davidt0x davidt0x commented Nov 17, 2024 •
edited
Loading

I think I screwed up the conditional for publishing releases. I think its supposed to be like this. Basing it off of https://github.com/scientific-python/cookie/blob/c7b897cf4f2f4d8f374d112d1fc694d92a2793a7/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/%7B%25%20if%20cookiecutter.__type%3D%3D'compiled'%20%25%7Dcd.yml%7B%25%20endif%20%25%7D#L67

This should allow it to be triggered by clicking creating a new release through the github page.

@mihaic mihaic added this pull request to the merge queue Nov 17, 2024
Merged via the queue into master with commit 7962502 Nov 17, 2024
12 of 42 checks passed
@mihaic mihaic deleted the fix_release branch November 17, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaic mihaic mihaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidt0x @mihaic
0