8000 Various fixes for v0.1 by mihaic · Pull Request #59 · brainiak/brainiak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Various fixes for v0.1 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*.o

brainiak.egg-info
build
.cache
.coverage
coverage.xml
Expand Down
17 changes: 4 additions & 13 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,12 @@ steps::
pip install .


Building documentation
----------------------
Documentation
-------------

The documentation will soon be available online. Until then, you can build it
yourself after installing the required tools::
The documentation is available at::

pip3 install -U sphinx sphinx_rtd_theme

Then, assuming you're already in the ``brainiak`` folder, do::

cd docs
make

This will generate HTML documentation in the ``_build/html`` folder within the
``docs`` folder. ``_build/html/index.html`` is the starting page.
https://pythonhosted.org/brainiak


Contribute
Expand Down
2 changes: 1 addition & 1 deletion brainiak/factor_analysis/tfa.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from scipy.optimize import linear_sum_assignment
from scipy.spatial import distance
from ..utils.utils import from_tri_2_sym, from_sym_2_tri
import tfa_extension
from . import tfa_extension
import numpy as np
import math
import gc
Expand Down
File renamed without changes.
2 changes: 2 additions & 0 deletions examples/functional_alignment/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
matplotlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notebook will also be needed for this example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Anything else?

notebook
1 change: 0 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
flake8
flake8-print
notebook
pytest
pytest-cov
restructuredtext-lint
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[aliases]
test = pytest

[pytest]
addopts =
--junitxml=junit-results.xml
Expand Down
15 changes: 8 additions & 7 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import sys
import setuptools

__version__ = '0.0.1'
__version__ = '0.1'

assert sys.version_info >= (3, 4), (
"Please use Python version 3.4 or higher, "
Expand Down Expand Up @@ -35,14 +35,13 @@ def __str__(self):

ext_modules = [
Extension(
'tfa_extension',
'brainiak.factor_analysis.tfa_extension',
['brainiak/factor_analysis/tfa_extension.cpp'],
include_dirs=[
# Path to pybind11 headers
get_pybind_include(),
get_pybind_include(user=True)
],
language='c++'
),
]

Expand Down Expand Up @@ -80,7 +79,7 @@ def cpp_flag(compiler):
class BuildExt(build_ext):
"""A custom build extension for adding compiler-specific options."""
c_opts = {
'unix': ['-std=c++11'],
'unix': ['-g0', '-fopenmp'],
}

if sys.platform == 'darwin':
Expand All @@ -91,12 +90,14 @@ def build_extensions(self):
ct = self.compiler.compiler_type
opts = self.c_opts.get(ct, [])
if ct == 'unix':
opts.append('-DVERSION_INFO="%s"' % self.distribution.get_version())
opts.append('-DVERSION_INFO="%s"' %
self.distribution.get_version())
opts.append(cpp_flag(self.compiler))
if has_flag(self.compiler, '-fvisibility=hidden'):
opts.append('-fvisibility=hidden')
for ext in self.extensions:
ext.extra_compile_args = opts
ext.extra_link_args = opts
build_ext.build_extensions(self)

setup(
Expand All @@ -112,12 +113,12 @@ def build_extensions(self):
author='Princeton Neuroscience Institute and Intel Corporation',
author_email='bryn.keller@intel.com',
url='https://github.com/IntelPNI/brainiak',
description='Scalable algorithms for advanced fMRI analysis',
description='Brain Imaging Analysis Kit',
license='Apache 2',
keywords='neuroscience, algorithm, fMRI, distributed, scalable',
long_description=long_description,
ext_modules=ext_modules,
cmdclass={'build_ext': BuildExt},
packages=find_packages(exclude=['doc', 'test']),
packages=find_packages(),
zip_safe=False,
)
0