8000 Fix for GH-69 by calvn · Pull Request #70 · breser/git2consul · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix for GH-69 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2016
Merged

Fix for GH-69 #70

merged 2 commits into from
Mar 29, 2016

Conversation

calvn
Copy link
Contributor
@calvn calvn commented Mar 29, 2016

Have config_reader.read() inside config_seeder.set()'s cb

@maclennann @ryanbreen please take a look to see if I missed anything.

@maclennann
Copy link

I'm not intimately familiar with git2consul, but based on the bug you told me about, this LGTM.

@calvn calvn merged commit 18c2323 into breser:master Mar 29, 2016
@juicedM3 juicedM3 mentioned this pull request Mar 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvn @maclennann
0