8000 Adjust late move reduction based on continuation history by brunocodutra · Pull Request #806 · brunocodutra/cinder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjust late move reduction based on continuation history #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025
Merged

Adjust late move reduction based on continuation history #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 65 additions & 64 deletions lib/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,70 +129,71 @@ macro_rules! params {

params! {
value_scale: Param<524288, 0>,
moves_left_start: Param<697292>,
moves_left_end: Param<9788>,
soft_time_fraction: Param<2464>,
hard_time_fraction: Param<3274>,
score_trend_inertia: Param<26033>,
pv_focus_gamma: Param<7796>,
pv_focus_delta: Param<8800>,
score_trend_magnitude: Param<2316>,
score_trend_pivot: Param<231467>,
quiet_history_bonus_gamma: Param<6312>,
quiet_history_bonus_delta: Param<1161>,
noisy_history_bonus_gamma: Param<6772>,
noisy_history_bonus_delta: Param<1168>,
quiet_continuation_bonus_gamma: Param<7406>,
quiet_continuation_bonus_delta: Param<508>,
noisy_continuation_bonus_gamma: Param<7633>,
noisy_continuation_bonus_delta: Param<1139>,
quiet_history_penalty_gamma: Param<7879>,
quiet_history_penalty_delta: Param<1781>,
noisy_history_penalty_gamma: Param<6629>,
noisy_history_penalty_delta: Param<2123>,
quiet_continuation_penalty_gamma: Param<7343>,
quiet_continuation_penalty_delta: Param<990>,
noisy_continuation_penalty_gamma: Param<7812>,
noisy_continuation_penalty_delta: Param<553>,
continuation_scale_1: Param<4471>,
null_move_reduction_gamma: Param<53773>,
null_move_reduction_delta: Param<42808>,
fail_high_reduction_gamma: Param<464542>,
fail_high_reduction_delta: Param<233308>,
fail_low_reduction_gamma: Param<1556236>,
fail_low_reduction_delta: Param<353921>,
single_extension_margin_gamma: Param<3116>,
single_extension_margin_delta: Param<1259>,
double_extension_margin_gamma: Param<4406>,
double_extension_margin_delta: Param<1696>,
triple_extension_margin_gamma: Param<3283>,
triple_extension_margin_delta: Param<593471>,
razoring_margin_gamma: Param<276805>,
razoring_margin_delta: Param<161804>,
reverse_futility_margin_gamma: Param<54077>,
reverse_futility_margin_delta: Param<30370>,
futility_margin_gamma: Param<159754>,
futility_margin_delta: Param<271506>,
futility_pruning_threshold_gamma: Param<37192>,
see_pruning_threshold_gamma: Param<239747>,
late_move_reduction_gamma: Param<1357>,
late_move_reduction_delta: Param<2865>,
late_move_reduction_pv: Param<4292>,
late_move_reduction_cut: Param<4334>,
late_move_reduction_improving: Param<1534>,
late_move_reduction_history: Param<4380>,
late_move_reduction_killer: Param<4223>,
late_move_reduction_check: Param<4118>,
late_move_reduction_tt_noisy: Param<4102>,
late_move_pruning_gamma: Param<1933>,
late_move_pruning_delta: Param<4853>,
killer_move_bonus: Param<216731>,
continuation_rating_scale_1: Param<5235>,
noisy_gain_rating_gamma: Param<6129>,
noisy_gain_rating_delta: Param<58527>,
aspiration_window_start: Param<18582>,
aspiration_window_gamma: Param<5461>,
aspiration_window_delta: Param<6111>,
moves_left_start: Param<736629>,
moves_left_end: Param<9098>,
soft_time_fraction: Param<2829>,
hard_time_fraction: Param<3258>,
score_trend_inertia: Param<26635>,
pv_focus_gamma: Param<6909>,
pv_focus_delta: Param<7832>,
score_trend_magnitude: Param<3093>,
score_trend_pivot: Param<205109>,
quiet_history_bonus_gamma: Param<6965>,
quiet_history_bonus_delta: Param<1271>,
noisy_history_bonus_gamma: Param<6863>,
noisy_history_bonus_delta: Param<1076>,
quiet_continuation_bonus_gamma: Param<7993>,
quiet_continuation_bonus_delta: Param<298>,
noisy_continuation_bonus_gamma: Param<8574>,
noisy_continuation_bonus_delta: Param<1476>,
quiet_history_penalty_gamma: Param<9126>,
quiet_history_penalty_delta: Param<2208>,
noisy_history_penalty_gamma: Param<7365>,
noisy_history_penalty_delta: Param<2266>,
quiet_continuation_penalty_gamma: Param<8448>,
quiet_continuation_penalty_delta: Param<1223>,
noisy_continuation_penalty_gamma: Param<7969>,
noisy_continuation_penalty_delta: Param<515>,
null_move_reduction_gamma: Param<56651>,
null_move_reduction_delta: Param<39193>,
fail_high_reduction_gamma: Param<437596>,
fail_high_reduction_delta: Param<236117>,
fail_low_reduction_gamma: Param<1582341>,
fail_low_reduction_delta: Param<362258>,
single_extension_margin_gamma: Param<3040>,
single_extension_margin_delta: Param<1391>,
double_extension_margin_gamma: Param<4276>,
double_extension_margin_delta: Param<1398>,
triple_extension_margin_gamma: Param<2838>,
triple_extension_margin_delta: Param<553652>,
razoring_margin_gamma: Param<254471>,
razoring_margin_delta: Param<164557>,
reverse_futility_margin_gamma: Param<60237>,
reverse_futility_margin_delta: Param<31144>,
futility_margin_gamma: Param<162269>,
futility_margin_delta: Param<266251>,
futility_pruning_threshold: Param<40055>,
see_pruning_threshold: Param<250703>,
late_move_reduction_gamma: Param<1284>,
late_move_reduction_delta: Param<3102>,
late_move_reduction_pv: Param<4352>,
late_move_reduction_cut: Param<4627>,
late_move_reduction_improving: Param<1157>,
late_move_reduction_history: Param<4701>,
late_move_reduction_continuation: Param<4383>,
late_move_reduction_killer: Param<4075>,
late_move_reduction_check: Param<3638>,
late_move_reduction_tt_noisy: Param<4002>,
late_move_pruning_gamma: Param<2049>,
late_move_pruning_delta: Param<4469>,
killer_move_bonus: Param<234000>,
history_rating: Param<4504>,
continuation_rating: Param<5827>,
winning_rating_gamma: Param<6643>,
winning_rating_delta: Param<60372>,
aspiration_window_start: Param<17850>,
aspiration_window_gamma: Param<5164>,
aspiration_window_delta: Param<6274>,
}

#[cfg(test)]
Expand Down
35 changes: 18 additions & 17 deletions lib/search/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ impl<'a> Stack<'a> {

let offset = 2 * m.is_quiet() as usize;
let (gamma, delta) = (params[offset], params[offset + 1]);
Params::continuation_scale_1() * ((gamma * depth.cast::<i32>() + delta) / Params::BASE)
/ Params::BASE
(gamma * depth.cast::<i32>() + delta) / Params::BASE
}

fn history_penalty(&self, m: Move, depth: Depth) -> i32 {
Expand All @@ -162,8 +161,7 @@ impl<'a> Stack<'a> {

let offset = 2 * m.is_quiet() as usize;
let (gamma, delta) = (params[offset], params[offset + 1]);
-Params::continuation_scale_1() * ((gamma * depth.cast::<i32>() + delta) / Params::BASE)
/ Params::BASE
-(gamma * depth.cast::<i32>() + delta) / Params::BASE
}

/// A measure for how much the position is improving.
Expand Down Expand Up @@ -276,13 +274,13 @@ impl<'a> Stack<'a> {

/// Computes the futility pruning threshold.
fn fpt(&self, depth: Depth) -> i32 {
let gamma = Params::futility_pruning_threshold_gamma();
let gamma = Params::futility_pruning_threshold();
gamma * depth.cast::<i32>() / Params::BASE
}

/// Computes the SEE pruning threshold.
fn spt(&self, depth: Depth) -> i32 {
let gamma = Params::see_pruning_threshold_gamma();
let gamma = Params::see_pruning_threshold();
gamma * depth.cast::<i32>() / Params::BASE
}

Expand Down Expand Up @@ -447,25 +445,25 @@ impl<'a> Stack<'a> {
return Bounded::upper();
}

let mut rating = Bounded::new(0);
rating += self.searcher.history.get(&self.evaluator, m).cast::<i32>();
let mut rating = 0i32;
rating += Params::history_rating()
* self.searcher.history.get(&self.evaluator, m).cast::<i32>();

let reply = self.replies.get(ply.cast::<usize>().wrapping_sub(1));
rating += Params::continuation_rating_scale_1() * reply.get(&self.evaluator, m) as i32
/ Params::BASE;
rating += Params::continuation_rating() * reply.get(&self.evaluator, m).cast::<i32>();

if killer.contains(m) {
rating += Params::killer_move_bonus() / Params::BASE;
rating += Params::killer_move_bonus();
} else if !m.is_quiet() {
let gain = self.evaluator.gain(m);
if self.evaluator.winning(m, Value::new(1)) {
let gamma = Params::noisy_gain_rating_gamma();
let delta = Params::noisy_gain_rating_delta();
rating += (gamma * gain.cast::<i32>() + delta) / Params::BASE;
let gamma = Params::winning_rating_gamma();
let delta = Params::winning_rating_delta();
rating += gamma * gain.cast::<i32>() + delta;
}
}

rating
(rating / Params::BASE).saturate()
});

#[allow(clippy::blocks_in_conditions)]
Expand Down Expand Up @@ -524,13 +522,16 @@ impl<'a> Stack<'a> {
}
}

let rating = self.searcher.history.get(&self.evaluator, m).cast::<i32>();
let reply = self.replies.get(ply.cast::<usize>().wrapping_sub(1));
603B let continuation = reply.get(&self.evaluator, m).cast::<i32>();
let history = self.searcher.history.get(&self.evaluator, m).cast::<i32>();
let mut next = self.next(Some(m));

lmr -= is_pv as i32 * Params::late_move_reduction_pv();
lmr -= killer.contains(m) as i32 * Params::late_move_reduction_killer();
lmr -= next.evaluator.is_check() as i32 * Params::late_move_reduction_check();
lmr -= rating * Params::late_move_reduction_history() / 128;
lmr -= history * Params::late_move_reduction_history() / 128;
lmr -= continuation * Params::late_move_reduction_continuation() / 128;
lmr -= improving * Params::late_move_reduction_improving();
lmr += cut as i32 * Params::late_move_reduction_cut();
lmr += transposed.head().is_some_and(|m| !m.is_quiet()) as i32
Expand Down
0