Add read_until_delimiter macro #2259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fd7248 to
74d16a6
Compare
This macro reads from an input stream byte by byte until a specified delimiter is found, writing each byte to an output stream. It returns the number of bytes read (excluding the delimiter) or an error. Key features: - Unified function handles both single character and multi-character delimiters - Reads byte-by-byte until delimiter is encountered - Writes data to output stream as it reads - Proper error handling for EOF and write failures - Compile-time type checking with @require constraints - Optimized pattern matching for multi-character delimiters Potential use cases: - Parse HTTP headers (read until '\r\n') - Extract fields from CSV files (read until ',') - Parse configuration files (read until '=') - Process line-based protocols - Extract tokens from streams Added comprehensive tests covering: - Basic functionality with single and multi-character delimiters - EOF handling when delimiter not found - Empty input streams and empty delimiters - Immediate delimiter at start - Partial matches that don't complete - Output stream write failures
74d16a6 to
76deeaf
Compare
|
It might be worth adding |
|
Delimiter should be char[]. Temp allocation here is a bit unfortunate, and wrapping it in a |
|
This will not work for the following example: Data: Delimiter: The code will not find the delimiter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro reads from an input stream byte by byte until a specified delimiter is found, writing each byte to an output stream. It returns the number of bytes read (excluding the delimiter) or an error.
Key features:
Potential use cases:
Added comprehensive tests covering: